-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata: escape display name in email addresses #1832
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
144fd74
to
1b3d8f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you also add a test case for the new function?
Co-authored-by: messense <[email protected]>
@messense tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
https://build.opensuse.org/request/show/1126453 by user mia + anag+factory - Update to 1.3.2 * Switch to Ruff formatter gh#PyO3/maturin#1817 * Upgrade ring to 0.17 gh#PyO3/maturin#1819 * Un-deprecate MATURIN_PEP517_ARGS env var gh#PyO3/maturin#1820 * Add support for uniffi library mode gh#PyO3/maturin#1729 * Fix missing member in Cargo.toml for sdist of nested workspace layout gh#PyO3/maturin#1828 * Metadata: escape display name in email addresses gh#PyO3/maturin#1832 * Fix rewriting workspace Cargo.toml in sdist gh#PyO3/maturin#1841 * Fix glob workspace members matching in sdist gh#PyO3/maturin#1846 * Add sdist tests for well-known downstream repositories gh#PyO3/maturin#1849
This follows the way setuptools handles email addresses from
pyproject.toml
files.See here where it utilizes the std lib package
email
, which in turn escapes email addresses here and then here.I noticed this bug when I tried to upload a package to PyPI with something like this in my
pyproject.toml
:PyPI rejected the package:
As a workaround, I changed my pyproject.toml to