Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set MACOSX_DEPLOYMENT_TARGET for editable builds by default #1815

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

messense
Copy link
Member

Closes #1804

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 6c27172
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6537b2c18e489a0008d71d50
😎 Deploy Preview https://deploy-preview-1815--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messense messense merged commit a8f87fd into PyO3:main Oct 24, 2023
28 of 29 checks passed
@messense messense deleted the editable-no-macos-deployment-target branch October 24, 2023 12:34
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Nov 7, 2023
https://build.opensuse.org/request/show/1123696
by user mia + anag+factory
- Update to 1.3.1
  * Use external uniffi-bindgen if no root package is configured
    gh#PyO3/maturin#1797
  * Add trusted publishing section to the user guide
    gh#PyO3/maturin#1800
  * Fix wheel filename for GraalPy
    gh#PyO3/maturin#1802
  * Pytest skeleton in mixed template
    gh#PyO3/maturin#1807
  * Keep trailing newlines from templates
    gh#PyO3/maturin#1808
  * Bump rustix from 0.37.23 to 0.37.25
    gh#PyO3/maturin#1809
  * Auto detect Python 3.13
    gh#PyO3/maturin#1810
  * Fix missing workspace.members in sdist
    gh#PyO3/maturin#1811
  * Don't set MACOSX_DEPLOYMENT_TARGET for editable builds
    gh#PyO3/maturin#1815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MACOSX_DEPLOYMENT_TARGET causing spurious rebuilds due to objc-sys
1 participant