Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep dev-dependencies in sdist when there are no path dependencies #1441

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

messense
Copy link
Member

@messense messense commented Jan 31, 2023

Rewrite Cargo.toml without sync with Cargo.lock breaks building from sdist with --locked/--frozen

  cargo build --manifest-path Cargo.toml --message-format=json-render-diagnostics --target x86_64-unknown-linux-gnu --release -v --locked
      Updating crates.io index
       Running `git fetch --force --update-head-ok 'https://github.com/rust-lang/crates.io-index' '+HEAD:refs/remotes/origin/HEAD'`
  error: the lock file /home/conda/feedstock_root/build_artifacts/maturin_1675149830257/work/Cargo.lock needs to be updated but --locked was passed to prevent this
  If you want to try to generate the lock file without accessing the network, remove the --locked flag and use --offline instead.
  error: `cargo build --manifest-path Cargo.toml --message-format=json-render-diagnostics --target x86_64-unknown-linux-gnu --release -v --locked` failed with code 101
  error: subprocess-exited-with-error

See conda-forge/maturin-feedstock#84

@messense messense added the sdist Source distribution label Jan 31, 2023
@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 61ff70e
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/63d8d75f667a2b0009e4ddd9
😎 Deploy Preview https://deploy-preview-1441--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense changed the title Fix building from sdist with --locked Keep dev-dependencies in sdist when there are no path dependencies Jan 31, 2023
@messense messense marked this pull request as ready for review January 31, 2023 08:39
@messense messense merged commit e134edf into PyO3:main Jan 31, 2023
@messense messense deleted the fix-sdist-locked branch January 31, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdist Source distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant