Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add riscv64 target support for FreeBSD #1313

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Add riscv64 target support for FreeBSD #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91aa870
Add riscv64 target support for FreeBSD
messense Nov 30, 2022
ec3544e
Fix powerpc64 and powerpc64le Python wheel platform tag for FreeBSD
messense Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Fix wrong platform tag when building in armv7 docker container on aarch64 host in [#1303](https://github.com/PyO3/maturin/pull/1303)
* Add Solaris operating system support in [#1310](https://github.com/PyO3/maturin/pull/1310)
* Add armv6 and armv7 target support for FreeBSD in [#1312](https://github.com/PyO3/maturin/pull/1312)
* Add riscv64 and powerpc target support for FreeBSD in [#1313](https://github.com/PyO3/maturin/pull/1313)
* Fix powerpc64 and powerpc64le Python wheel platform tag for FreeBSD in [#1313](https://github.com/PyO3/maturin/pull/1313)

## [0.14.2] - 2022-11-24

Expand Down
7 changes: 5 additions & 2 deletions src/target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ fn get_supported_architectures(os: &Os) -> Vec<Arch> {
Arch::Powerpc64Le,
Arch::X86,
Arch::X86_64,
Arch::Riscv64,
],
Os::OpenBsd => vec![Arch::X86, Arch::X86_64, Arch::Aarch64],
Os::Dragonfly => vec![Arch::X86_64],
Expand Down Expand Up @@ -240,8 +241,10 @@ impl Target {
| (Os::FreeBsd, Arch::Aarch64)
| (Os::FreeBsd, Arch::Armv6L)
| (Os::FreeBsd, Arch::Armv7L)
| (Os::FreeBsd, Arch::Powerpc)
| (Os::FreeBsd, Arch::Powerpc64)
| (Os::FreeBsd, Arch::Powerpc64Le)
| (Os::FreeBsd, Arch::Riscv64)
// NetBSD
| (Os::NetBsd, Arch::X86)
| (Os::NetBsd, Arch::X86_64)
Expand All @@ -256,8 +259,8 @@ impl Target {
Arch::X86 => "i386",
Arch::Aarch64 => "arm64",
Arch::Armv6L | Arch::Armv7L => "arm",
Arch::Powerpc64 => "powerpc64",
Arch::Powerpc64Le => "powerpc64le",
Arch::Powerpc | Arch::Powerpc64 | Arch::Powerpc64Le => "powerpc",
Copy link
Member Author

@messense messense Nov 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per

maturin/sysconfig/cpython-freebsd-13.0-powerpc64.txt

Line 1 in 4d61475

Platform: "freebsd-13.0-RELEASE-p4-powerpc"

and

maturin/sysconfig/cpython-freebsd-13.0-powerpc64le.txt

Line 1 in 4d61475

Platform: "freebsd-13.0-RELEASE-p4-powerpc"

They are all just powerpc.

Arch::Riscv64 => "riscv",
_ => panic!(
"unsupported architecture should not have reached get_platform_tag()"
),
Expand Down
Loading