Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditwheel: allow bin bindings to link to libpython #1270

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

messense
Copy link
Member

bin bindings link to libpython is totally fine, only extension modules should not link to libpython to be able to work in both static and shared library Python interpreter flavors.

@messense messense added wheel Wheel bindings/bin bin bindings labels Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit d15b99f
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6373071dcca4f400085a32e2
😎 Deploy Preview https://deploy-preview-1270--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense added this to the 0.14.0 milestone Nov 15, 2022
@messense
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 15, 2022

@bors bors bot merged commit 4ba89d9 into PyO3:main Nov 15, 2022
@messense messense deleted the bin-libpython branch November 27, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings/bin bin bindings wheel Wheel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant