Lookup inherited build- and dev-dependencies in dependencies #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the docs in https://doc.rust-lang.org/stable/cargo/reference/workspaces.html#the-workspacedependencies-table and https://doc.rust-lang.org/stable/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace which says Dependencies in the [dependencies], [dev-dependencies], [build-dependencies], and [target."...".dependencies] sections support the ability to reference the [workspace.dependencies] definition of dependencies. So, we should not lookup build- and dev-dependencies in their workspace.* equivalent but only in workspace.dependencies
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! bors r+ |
|
bors ping |
|
pong |
|
bors r+ |
|
Merge conflict. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 11, 2022
1261: Lookup inherited build- and dev-dependencies in dependencies r=messense a=knutwalker Following the docs in https://doc.rust-lang.org/stable/cargo/reference/workspaces.html#the-workspacedependencies-table and https://doc.rust-lang.org/stable/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace which says Dependencies in the [dependencies], [dev-dependencies], [build-dependencies], and [target."...".dependencies] sections support the ability to reference the [workspace.dependencies] definition of dependencies. So, we should not lookup build- and dev-dependencies in their workspace.* equivalent but only in workspace.dependencies Co-authored-by: Paul Horn <[email protected]> Co-authored-by: messense <[email protected]>
|
Looks like the macOS runner is stuck, merging manually. |
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the docs in https://doc.rust-lang.org/stable/cargo/reference/workspaces.html#the-workspacedependencies-table
and https://doc.rust-lang.org/stable/cargo/reference/specifying-dependencies.html#inheriting-a-dependency-from-a-workspace
which says
So, we should not lookup build- and dev-dependencies in their workspace.* equivalent but only in workspace.dependencies