Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdist build for maturin itself #1198

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

messense
Copy link
Member

cargo run sdist
   Compiling maturin v0.13.6 (/Users/messense/Projects/maturin)
    Finished dev [unoptimized + debuginfo] target(s) in 2.28s
     Running `target/debug/maturin sdist`
⚠️  Warning: `build-backend` in pyproject.toml is not set to `maturin`, packaging tools such as pip will not use maturin to build this project.
🍹 Building a mixed python/rust project
🔗 Found bin bindings
📡 Using build options bindings from pyproject.toml
💥 maturin failed
  Caused by: Failed to build source distribution
  Caused by: prefix not found

@messense messense added the sdist Source distribution label Oct 14, 2022
@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 3ba5bea
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6349231954bbee00085bad55
😎 Deploy Preview https://deploy-preview-1198--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense added this to the 0.14.0 milestone Oct 14, 2022
```
cargo run sdist
   Compiling maturin v0.13.6 (/Users/messense/Projects/maturin)
    Finished dev [unoptimized + debuginfo] target(s) in 2.28s
     Running `target/debug/maturin sdist`
⚠️  Warning: `build-backend` in pyproject.toml is not set to `maturin`, packaging tools such as pip will not use maturin to build this project.
🍹 Building a mixed python/rust project
🔗 Found bin bindings
📡 Using build options bindings from pyproject.toml
💥 maturin failed
  Caused by: Failed to build source distribution
  Caused by: prefix not found
```
@messense
Copy link
Member Author

Will do a refactoring later to unify relative/absolute path handling related to strip_prefix.

@messense messense merged commit 71b54eb into PyO3:main Oct 14, 2022
@messense messense deleted the fix-sdist-maturin branch October 14, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdist Source distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant