Change python-source to be relative to the file specifies it
#1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Now that project root is changed to the directory containing `pyproject.toml` in PyO3#1044, `python-source` specified in `Cargo.toml` should be treated as relative to `Cargo.toml`. We should also change `data` to do the same.
messense
force-pushed
the
python-source-relative
branch
from
7d5751c to
9c9abf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that project root is changed to the directory containing
pyproject.tomlin #1044,python-sourcespecified inCargo.tomlshould be treated as relative to
Cargo.toml.We should also change
datato do the same.