Fix path search upon python3 -m maturin
#1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sysconfig.get_path` was insufficient on my machine as it was unable to resolve my `scripts` directory without an explicit `scheme="nt_user"` invocation (Windows 11 running Python 3.10.6). Intention here was to implement a more generic method of resolving `scripts` directories. There may be more idiomatic ways to achieve this behavior, as well as more useful error messages than what are provided in this solution.
✅ Deploy Preview for maturin-guide canceled.Built without sensitive environment variables
|
In my haste to submit a pull-request I neglected to check format. Apologies.
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 15, 2022
https://build.opensuse.org/request/show/995047 by user mia + dimstar_suse - Update to v0.13.2 * Add Linux mips64el architecture support gh#PyO3/maturin#1023 * Add Linux mipsel architecture support gh#PyO3/maturin#1024 * Add Linux 32-bit powerpc architecture support gh#PyO3/maturin#1026 * Add Linux sparc64 architecture support gh#PyO3/maturin#1027 * Bump anyhow from 1.0.58 to 1.0.59 gh#PyO3/maturin#1031 * Bump serde from 1.0.140 to 1.0.141 gh#PyO3/maturin#1032 * Bump clap from 3.2.15 to 3.2.16 gh#PyO3/maturin#1033 * Bump tracing from 0.1.35 to 0.1.36 gh#PyO3/maturin#1035 * Bump dialoguer from 0.10.1 to 0.10.2 gh#PyO3/maturin#1034 * Add PEP 440 local version identifier support gh#PyO3/maturin#1037 * Fix path search upon python3 -m maturin gh#PyO3/maturin#1038 * Update cargo-zigbuild to 0.12.0 g
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysconfig.get_pathwas insufficient on my machine as it was unable to resolve myscriptsdirectory without an explicitscheme="nt_user"invocation (Windows 11 running Python 3.10.6). Intention here was to implement a more generic method of resolvingscriptsdirectories. There may be more idiomatic ways to achieve this behavior, as well as more useful error messages than what are provided in this solution.