-
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 64-bit RISC-V support #1001
Conversation
Tested with `orjson` and it built fine with all tests passed on a riscv64 machine. This change is not sufficient though, because `ring` doesn't support riscv64 yet. I was building `maturin` against a custom version of `ring` to verify this change. Please let me know what could be done to move forward :)
✅ Deploy Preview for maturin-guide canceled.Built without sensitive environment variables
|
Thanks, please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix the code format issue after merging.
Thanks! I was about to do it :P |
Since ring doesn't support RISC-V yet, we should also add it to Lines 49 to 52 in 1339808
@felixonmars do you know what does |
|
add-riscv64-support.patch was backported from PyO3/maturin#1001
add-riscv64-support.patch was backported from PyO3/maturin#1001
Released in v0.13.1. |
https://build.opensuse.org/request/show/991319 by user mia + dimstar_suse - Update to v0.13.1 * Add 64-bit RISC-V support gh#PyO3/maturin#1001 * Run tests on CI with cargo-nextest gh#PyO3/maturin#1004 * Add support for invoking with python3 -m maturin gh#PyO3/maturin#1008 * Consider pyproject.toml features when detecting pyo3 gh#PyO3/maturin#1014 * Respect user specified Rust target in maturin develop gh#PyO3/maturin#1016 * Use cargo rustc --crate-type cdylib on Rust nightly/dev channel gh#PyO3/maturin#1020 * Use cargo-nextest in test-alpine gh#PyO3/maturin#1021 - Update to v0.13.0 * Drop python 3.6 by @konstin in #945 * Add support for building with multiple binary targets by @messense in #948 * Add a --target option to maturin list-python command by @messense in #957 * Add support for using bundled pyth
Tested with
orjson
and it built fine with all tests passed on ariscv64 machine.
This change is not sufficient though, because
ring
doesn't supportriscv64 yet. I was building
maturin
against a custom version ofring
to verify this change.
Please let me know what could be done to move forward :)