Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maturin is not able to auto-discover Python 3.10 on Windows #614

Closed
bernardelli opened this issue Sep 1, 2021 · 2 comments · Fixed by #630
Closed

Maturin is not able to auto-discover Python 3.10 on Windows #614

bernardelli opened this issue Sep 1, 2021 · 2 comments · Fixed by #630

Comments

@bernardelli
Copy link

Auto-discover can't find Python 3.10 on Windows.

I believe that the regex expression Regex::new(r" -(\d).(\d)-(\d+)(?: .*)?") at this line is responsible for that.
Shouldn't it be Regex::new(r" -(\d).(\d+)-(\d+)(?: .*)?")?.

For context, see the script below:

choco install -y rust-ms --no-progress
# install stable python versions
foreach ($PyVersion in @("3.6.8", "3.7.9", "3.8.10", "3.9.6"))
      { choco install -my python --version=${PyVersion} --no-progress }
# install python previews
foreach ($PyVersion in @("3.10.0-rc1"))
      { choco install -my python --version=${PyVersion}  --pre --no-progress }
pip install --no-cache-dir maturin
maturin publish [...]

I don't thing this is relevant, but I'm using pip version 21.1.3 and pyo3 bindings.

By the way, thanks for the amazing work!

@bernardelli bernardelli changed the title Maturin is not able to auto-discoverPython 3.10 on Windows Maturin is not able to auto-discover Python 3.10 on Windows Sep 1, 2021
@messense
Copy link
Member

messense commented Sep 1, 2021

Would you like send a PR to fix it?

@bernardelli
Copy link
Author

Sure, I am going to do it in the next few days.

messense added a commit to messense/maturin that referenced this issue Sep 19, 2021
messense added a commit to messense/maturin that referenced this issue Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants