-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to disable rewriting path Cargo dependencies into local_dependencies/ folder #1586
Labels
Comments
I was thinking about adding a new "sdist generator". The current one can be called What do you think? |
That would work for me.
…On Tue, May 2, 2023 at 7:32 AM messense ***@***.***> wrote:
I was thinking about adding a new "sdist generator".
The current one can be called cargo, and we can add a new one called git
that generate sdist based on git ls-files with respect to include/exclude
options of [tool.maturin].
What do you think?
—
Reply to this email directly, view it on GitHub
<#1586 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBHUGMJ6RXBY24E243DXEDWF3ANCNFSM6AAAAAAXS4CS3M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
2 tasks
WIP in #1587. |
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
bors bot
added a commit
that referenced
this issue
May 4, 2023
1587: Introduce `git` source distribution generator r=konstin a=messense TODO: - [x] How to handle projects that live inside a subdirectory of a git repository? For example our `test-crates/*` - [x] Add a test case Closes #1586 Co-authored-by: messense <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now if you have a
{ path = ... }
dependency inCargo.toml
,maturin
will rewrite it to live inlocal_dependencies/
. I would like a way to disable this, and instead just handle things at their existing locations.@messense has suggested that this might also fix #1442
In terms of how to implement it, I can imagine two approaches:
rewrite-path-dependencies = [true/false]
option inpyproject.toml
include
inpyproject.toml
, then leave it as-is.The text was updated successfully, but these errors were encountered: