Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Target::get_platform_tag to use standard osname-release-machine fallback representation #1311

Closed
messense opened this issue Nov 29, 2022 · 0 comments · Fixed by #1318
Closed

Refactor Target::get_platform_tag to use standard osname-release-machine fallback representation #1311

messense opened this issue Nov 29, 2022 · 0 comments · Fixed by #1318
Labels
enhancement New feature or request

Comments

@messense
Copy link
Member

Reference: https://github.com/python/cpython/blob/74d5f61ebd1cb14907bf7dae1ad9c1e676707bc5/Lib/sysconfig.py#L743-L821
@messense messense added the enhancement New feature or request label Nov 29, 2022
@messense messense added this to the 1.0.0 milestone Nov 29, 2022
@messense messense mentioned this issue Dec 2, 2022
Merged
bors bot added a commit that referenced this issue Dec 2, 2022
@bors @messense
Merge #1318
bf6fea9 
1318: Refactor `Target::get_platform_tag` to use standard osname-release-machine fallback representation r=messense a=messense

Expanded architecture support for FreeBSD, NetBSD and OpenBSD, even though rustup might not have toolchain support for them, distro itself might already have toolchain support in its packaging system.

Closes #1311 

Co-authored-by: messense <[email protected]>
bors bot added a commit that referenced this issue Dec 2, 2022
@bors @messense
Merge #1318
bafb9ca 
1318: Refactor `Target::get_platform_tag` to use standard osname-release-machine fallback representation r=messense a=messense

Expanded architecture support for FreeBSD, NetBSD and OpenBSD, even though rustup might not have toolchain support for them, distro itself might already have toolchain support in its packaging system.

Closes #1311 

Co-authored-by: messense <[email protected]>
bors bot added a commit that referenced this issue Dec 2, 2022
@bors @messense
Merge #1318
2b83827 
1318: Refactor `Target::get_platform_tag` to use standard osname-release-machine fallback representation r=messense a=messense

Expanded architecture support for FreeBSD, NetBSD and OpenBSD, even though rustup might not have toolchain support for them, distro itself might already have toolchain support in its packaging system.

Closes #1311 

Co-authored-by: messense <[email protected]>
@bors bors bot closed this as completed in 6e7b02f Dec 2, 2022
@messense messense removed this from the 1.0.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@messense