-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce compile time when build maturin from source distribution #1306
Comments
With this, there could be a case where that wheel ends in the cache, and when the user runs What would work would be a separate maturin-core package as build backend like poetry-core, though i'm not sure if the benefits outweigh the complexity; platforms without prebuilt maturin are rare and there's the wheel cache so it only needs to be built once |
Good point, but IMO in this case they are unlikely to run
I also thought about this and came to the same conclusion. I think adding a env var like |
On second thought, what if we just make bootstrap from sdist use Most people should use prebuilt binary from PyPI or distro packaging channel, so bootstrap from sdist is often limited to
|
yeah that sounds reasonable |
In such situation when maturin is built from source for reasons like no prebuilt wheel available, pep517 build only needs the
maturin pep517
subcommand, we don't need to waste time building lots of dependencies for features likeupload
that won't be used.We should be able to detect PEP 517 isolated build environment by Python interpreter path, it will containbuild-env
:* https://github.com/pypa/build/blob/4475cf1bf2362cfba8dd8b10ac97b42d066db502/src/build/env.py#L99* https://github.com/pypa/pip/blob/5f3f592c4581a059ff9de0fb8052ef5c6ef25fd4/src/pip/_internal/utils/temp_dir.py#L19Slow to compile dependencies:
toml_edit
is pretty slow to compile toml-rs/toml#327The text was updated successfully, but these errors were encountered: