cargo install maturin fails on M1 Mac

[nishaq503]

Bug Description

There is a compilation error with cargo-xwin v0.10.2. I've pasted the error in the "Steps to Reproduce" section. I'm not sure if this issue should be raised here or with xwin.

Your Python version (python -V)

3.9.13

Your pip version (pip -V)

22.2.2

What bindings you're using

pyo3

Does cargo build work?

• Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

• Yes

Steps to Reproduce

I have a MacBook Pro with an M1 Max and my OS is macOS 12.4 21F79 arm64. I have rustc and cargo versions 1.64.0. I tried installing maturin using cargo install maturin. This is the compiler error:

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cargo-xwin-0.10.2/src/common.rs:238:22
    |
238 |         let pruned = xwin::prune_pkg_list(&pkg_manifest, arches, variants)?;
    |                      ^^^^^^^^^^^^^^^^^^^^--------------------------------- an argument of type `bool` is missing
    |
note: function defined here
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/xwin-0.2.8/src/lib.rs:263:8
    |
263 | pub fn prune_pkg_list(
    |        ^^^^^^^^^^^^^^
help: provide the argument
    |
238 |         let pruned = xwin::prune_pkg_list(&pkg_manifest, arches, variants, /* bool */)?;
    |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0308]: mismatched types
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cargo-xwin-0.10.2/src/common.rs:280:47
    |
280 |                 ProgressBar::with_draw_target(0, draw_target.into()).with_prefix(prefix).with_style(
    |                 ----------------------------- ^ expected enum `Option`, found integer
    |                 |
    |                 arguments to this function are incorrect
    |
    = note: expected enum `Option<u64>`
               found type `{integer}`
note: associated function defined here
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/indicatif-0.17.1/src/progress_bar.rs:52:12
    |
52  |     pub fn with_draw_target(len: Option<u64>, draw_target: ProgressDrawTarget) -> ProgressBar {
    |            ^^^^^^^^^^^^^^^^
help: try wrapping the expression in `Some`
    |
280 |                 ProgressBar::with_draw_target(Some(0), draw_target.into()).with_prefix(prefix).with_style(
    |                                               +++++ +

error[E0308]: mismatched types
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/cargo-xwin-0.10.2/src/common.rs:319:57
    |
319 |         let manifest_pb = ProgressBar::with_draw_target(0, dt.into())
    |                           ----------------------------- ^ expected enum `Option`, found integer
    |                           |
    |                           arguments to this function are incorrect
    |
    = note: expected enum `Option<u64>`
               found type `{integer}`
note: associated function defined here
   --> /Users/najibishaq/.cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/indicatif-0.17.1/src/progress_bar.rs:52:12
    |
52  |     pub fn with_draw_target(len: Option<u64>, draw_target: ProgressDrawTarget) -> ProgressBar {
    |            ^^^^^^^^^^^^^^^^
help: try wrapping the expression in `Some`
    |
319 |         let manifest_pb = ProgressBar::with_draw_target(Some(0), dt.into())

[konstin]

Happens platform independently, but it's fixed on main anymore since there it's cargo-xwin 0.11 instead of 0.10.2. You can use cargo install maturin --locked as a workaround for now. The problem is that cargo-xwin 0.10.2 used indicatif 0.17.0-rc.6 but didn't = pin the version, so cargo resolves this to the 0.17.1 release which is incompatible to the release candidate.

[nishaq503]

Thank you!

[messense]

I've updated the docs to use cargo install --locked: https://maturin.rs/installation.html#cratesio

IMO --locked should be preferred to ensure reproducible builds, and to use the exact same set of dependencies that were available when the package was published.

[kaimast]

Saw the same issue on Linux. Thanks for posting a workaround!

Did someone already create an issue with cargo-xwin or whatever is causing this?

[messense]

It's happening because the xwin crate does not adhere to semver because its primary interface is CLI.