Merge #1251

1251: Set default macOS deployment target version if not specified r=messense a=messense Fixes #1247 Co-authored-by: messense <[email protected]>
PyO3 · Nov 5, 2022 · e74b2a8 · e74b2a8
2 parents d6c6bed + 134f424
commit e74b2a8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/Changelog.md b/Changelog.md
@@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fix auditwheel `libpython` check on Python 3.7 and older versions in [#1229](https://github.com/PyO3/maturin/pull/1229)
 * Use generic tags when `sys.implementation.name` != `platform.python_implementation()` in [#1232](https://github.com/PyO3/maturin/pull/1232).
   Fixes the compatibility tags for Pyston.
+* Set default macOS deployment target version if `MACOSX_DEPLOYMENT_TARGET` isn't specified in [#1251](https://github.com/PyO3/maturin/pull/1251)
 
 ## [0.13.7] - 2022-10-29
 

diff --git a/src/compile.rs b/src/compile.rs
@@ -1,5 +1,5 @@
 use crate::build_context::BridgeModel;
-use crate::target::RUST_1_64_0;
+use crate::target::{Arch, RUST_1_64_0};
 use crate::{BuildContext, PlatformTag, PythonInterpreter, Target};
 use anyhow::{anyhow, bail, Context, Result};
 use fat_macho::FatWriter;
@@ -384,6 +384,15 @@ fn compile_target(
         build_command.env("PYO3_CROSS_LIB_DIR", lib_dir);
     }
 
+    // Set default macOS deployment target version
+    if target.is_macos() && env::var_os("MACOSX_DEPLOYMENT_TARGET").is_none() {
+        let min_version = match target.target_arch() {
+            Arch::Aarch64 => "11.0",
+            _ => "10.7",
+        };
+        build_command.env("MACOSX_DEPLOYMENT_TARGET", min_version);
+    }
+
     let mut cargo_build = build_command
         .spawn()
         .context("Failed to run `cargo rustc`")?;