Skip to content

Commit

Permalink
Merge #1271
Browse files Browse the repository at this point in the history
1271: Remove unnecessary `editable` tests r=messense a=messense

After #653, `develop` tests already covered `editable` since it uses editable installs internally

Co-authored-by: messense <[email protected]>
  • Loading branch information
bors[bot] and messense authored Nov 15, 2022
2 parents 4ba89d9 + 223f16b commit d02c1fb
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 128 deletions.
89 changes: 0 additions & 89 deletions tests/common/editable.rs

This file was deleted.

1 change: 0 additions & 1 deletion tests/common/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ use std::process::{Command, Stdio};
use std::{env, io, str};

pub mod develop;
pub mod editable;
pub mod errors;
pub mod integration;
pub mod other;
Expand Down
39 changes: 1 addition & 38 deletions tests/run.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
//! To speed up the tests, they are tests all collected in a single module
use common::{
develop, editable, errors, get_python_implementation, handle_result, integration, other,
test_python_path,
develop, errors, get_python_implementation, handle_result, integration, other, test_python_path,
};
use indoc::indoc;
use maturin::Target;
Expand Down Expand Up @@ -124,42 +123,6 @@ fn develop_pyo3_ffi_pure() {
));
}

#[test]
fn editable_pyo3_pure() {
handle_result(editable::test_editable(
"test-crates/pyo3-pure",
None,
"editable-pyo3-pure",
));
}

#[test]
fn editable_pyo3_mixed() {
handle_result(editable::test_editable(
"test-crates/pyo3-mixed",
None,
"editable-pyo3-mixed",
));
}

#[test]
fn editable_pyo3_mixed_py_subdir() {
handle_result(editable::test_editable(
"test-crates/pyo3-mixed-py-subdir",
None,
"editable-pyo3-mixed-py-subdir",
));
}

#[test]
fn editable_pyo3_ffi_pure() {
handle_result(editable::test_editable(
"test-crates/pyo3-ffi-pure",
None,
"editable-pyo3-ffi-pure",
));
}

#[test]
fn integration_pyo3_bin() {
let python = test_python_path().map(PathBuf::from).unwrap_or_else(|| {
Expand Down

0 comments on commit d02c1fb

Please sign in to comment.