Skip to content

Commit

Permalink
Don't check .gitignore files outside of projet directory
Browse files Browse the repository at this point in the history
When building inside a .gitignore'd output directory as part of
another build system maturin may accidentially pick up the parent
.gitignore. Lets just disable searching for parent .gitignore
files since this functionality is broken anyways as the logic does
not match git's .gitignore logic anyways.

For example in buildroot we have an output directory that has its
contents gitignored in which maturin will build packages, changing
some minor implementation details in how we ignore this directory
triggered this bug.

buildroot/buildroot@a14c862

As the output dir files are supposed to be ignored both before and
after this change this indicates that ignore::WalkBuilder parent
matching is fundamentally broken and can not be used reliably
in the first place as it does not match git's ignore logic.

Also disable git exclude and git global excludes which may cause
problems.

Signed-off-by: James Hilliard <[email protected]>
  • Loading branch information
jameshilliard committed Jul 25, 2024
1 parent 46cce03 commit ac0b8d8
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/module_writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,8 +1286,17 @@ pub fn write_python_part(
}

for package in python_packages {
for absolute in WalkBuilder::new(package).hidden(false).build() {
for absolute in WalkBuilder::new(&project_layout.rust_module)
.hidden(false)
.parents(false)
.git_global(false)
.git_exclude(false)
.build()
{
let absolute = absolute?.into_path();
if !absolute.starts_with(package.as_path()) {
continue;
}
let relative = absolute.strip_prefix(python_dir).unwrap();
if absolute.is_dir() {
writer.add_directory(relative)?;
Expand Down
1 change: 1 addition & 0 deletions test-crates/pyo3-mixed-implicit/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.py[cdo]
1 change: 1 addition & 0 deletions test-crates/pyo3-mixed-include-exclude/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.py[cdo]
1 change: 1 addition & 0 deletions test-crates/pyo3-mixed-py-subdir/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.py[cdo]
1 change: 1 addition & 0 deletions test-crates/pyo3-mixed-src/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.py[cdo]
1 change: 1 addition & 0 deletions test-crates/pyo3-mixed/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.py[cdo]
2 changes: 2 additions & 0 deletions tests/run.rs
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,7 @@ fn pyo3_mixed_include_exclude_sdist() {
SdistGenerator::Cargo,
expect![[r#"
{
"pyo3_mixed_include_exclude-2.1.3/.gitignore",
"pyo3_mixed_include_exclude-2.1.3/Cargo.lock",
"pyo3_mixed_include_exclude-2.1.3/Cargo.toml",
"pyo3_mixed_include_exclude-2.1.3/PKG-INFO",
Expand Down Expand Up @@ -759,6 +760,7 @@ fn pyo3_mixed_include_exclude_git_sdist_generator() {
SdistGenerator::Git,
expect![[r#"
{
"pyo3_mixed_include_exclude-2.1.3/.gitignore",
"pyo3_mixed_include_exclude-2.1.3/Cargo.lock",
"pyo3_mixed_include_exclude-2.1.3/Cargo.toml",
"pyo3_mixed_include_exclude-2.1.3/PKG-INFO",
Expand Down

0 comments on commit ac0b8d8

Please sign in to comment.