Merge pull request #452 from messense/auditwheel-no-symbol-versions

Improve error message when auditwheel failed to find versioned offending symbols
PyO3 · Mar 1, 2021 · 5bf64c8 · 5bf64c8
2 parents 3d5f2dd + 10a8487
commit 5bf64c8
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/src/auditwheel/mod.rs b/src/auditwheel/mod.rs
@@ -232,11 +232,19 @@ pub fn auditwheel_rs(
                     .map(|v| format!("{}_{}", name, v))
                     .collect();
                 let offending_symbols = find_incompliant_symbols(&elf, &offending_symbol_versions)?;
-                let offender = format!(
-                    "{} offending symbols: {}",
-                    library.name,
-                    offending_symbols.join(", ")
-                );
+                let offender = if offending_symbols.is_empty() {
+                    format!(
+                        "{} offending versions: {}",
+                        library.name,
+                        offending_symbol_versions.join(", ")
+                    )
+                } else {
+                    format!(
+                        "{} offending symbols: {}",
+                        library.name,
+                        offending_symbols.join(", ")
+                    )
+                };
                 offenders.insert(offender);
             }
         }