Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: drop precommit job, use bot, move docs into CI workflow #2594

Closed
wants to merge 22 commits into from

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Jul 3, 2023

Moving docs build to CI checks as this is not much lint but real check
Also, I may suggest installing recommit bot instead of GH action which has the advantage of eventually automatically fixing open PRs

cc: @EnricoMi

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d46173) 96.70% compared to head (96eb45c) 96.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   96.70%   96.70%           
=======================================
  Files         147      147           
  Lines       14885    14885           
=======================================
  Hits        14395    14395           
  Misses        490      490           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Borda
Copy link
Contributor Author

Borda commented Jul 17, 2023

@sfdye @EnricoMi could you pls have look / review 🦩

@EnricoMi
Copy link
Collaborator

I am fine with moving docs to CI. Can you elaborate on the automatically fixing PRs bit?

@Borda
Copy link
Contributor Author

Borda commented Jul 19, 2023

I am fine with moving docs to CI. Can you elaborate on the automatically fixing PRs bit?

if you install this bot (https://pre-commit.ci/) for org or just this repo it will automatically run recommit as configured within this repo and if the recommit generates any changes, it will be append as commit to the particular PR

@EnricoMi
Copy link
Collaborator

And this happens monthly?

  autoupdate_schedule: 'monthly'

@Borda
Copy link
Contributor Author

Borda commented Jul 19, 2023

And this happens monthly?

  autoupdate_schedule: 'monthly'

This means that every month bump hooks versions to the latest (via PR) or you can set weekly or quarterly... if you have all latest, no PR is created

@Borda
Copy link
Contributor Author

Borda commented Jul 25, 2023

@EnricoMi may we proceed with this update? 🐿️

@sfdye
Copy link
Member

sfdye commented Jul 25, 2023

No objection, let's do this

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not rename ci.yml file?

@EnricoMi EnricoMi changed the title ci: drop precommit job CI: drop precommit job, move docs into CI workflow Aug 9, 2023
@Borda
Copy link
Contributor Author

Borda commented Aug 9, 2023

Can we not rename ci.yml file?

@EnricoMi reverted

@Borda Borda requested a review from EnricoMi August 9, 2023 13:34
@EnricoMi
Copy link
Collaborator

EnricoMi commented Aug 9, 2023

No objection, let's do this

@sfdye you need to install this Github app: https://github.com/marketplace/pre-commit-ci

Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Borda
Copy link
Contributor Author

Borda commented Aug 9, 2023

LGTM!

cool, lets first install the bot 🎏

@EnricoMi EnricoMi changed the title CI: drop precommit job, move docs into CI workflow CI: drop precommit job, use bot, move docs into CI workflow Aug 9, 2023
@EnricoMi
Copy link
Collaborator

@sfdye I fear you will have to first install the bot in this repo, before I can merge this.

I do not have the necessary permissions to do that: https://github.com/marketplace/pre-commit-ci

@Borda
Copy link
Contributor Author

Borda commented Aug 29, 2023

@sfdye friendly reminder... 🦩

@Borda
Copy link
Contributor Author

Borda commented Nov 14, 2023

@EnricoMi is there anything I can do to help it land? 🦩

@EnricoMi
Copy link
Collaborator

Nope, nothing we can do.

@Borda
Copy link
Contributor Author

Borda commented Jul 14, 2024

@EnricoMi, shall we close this PR in such a case?

@Borda
Copy link
Contributor Author

Borda commented Nov 12, 2024

@EnricoMi, shall we close this PR in such a case?

ok, let's close it... 😿

@Borda Borda closed this Nov 12, 2024
@Borda Borda deleted the ci/lint branch November 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants