-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: drop precommit job, use bot, move docs into CI workflow #2594
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=======================================
Coverage 96.70% 96.70%
=======================================
Files 147 147
Lines 14885 14885
=======================================
Hits 14395 14395
Misses 490 490 ☔ View full report in Codecov by Sentry. |
I am fine with moving docs to CI. Can you elaborate on the automatically fixing PRs bit? |
if you install this bot (https://pre-commit.ci/) for org or just this repo it will automatically run recommit as configured within this repo and if the recommit generates any changes, it will be append as commit to the particular PR |
And this happens monthly?
|
This means that every month bump hooks versions to the latest (via PR) or you can set weekly or quarterly... if you have all latest, no PR is created |
@EnricoMi may we proceed with this update? 🐿️ |
No objection, let's do this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we not rename ci.yml
file?
@EnricoMi reverted |
@sfdye you need to install this Github app: https://github.com/marketplace/pre-commit-ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cool, lets first install the bot 🎏 |
@sfdye I fear you will have to first install the bot in this repo, before I can merge this. I do not have the necessary permissions to do that: https://github.com/marketplace/pre-commit-ci |
@sfdye friendly reminder... 🦩 |
@EnricoMi is there anything I can do to help it land? 🦩 |
Nope, nothing we can do. |
@EnricoMi, shall we close this PR in such a case? |
ok, let's close it... 😿 |
Moving docs build to CI checks as this is not much lint but real check
Also, I may suggest installing recommit bot instead of GH action which has the advantage of eventually automatically fixing open PRs
cc: @EnricoMi