Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TarFS.geturl and ZipFS.geturl and Fix #329, #333, #340 #330

Merged
merged 42 commits into from
Aug 23, 2019
Merged
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b0fd465
:sparkles: provide geturl for ReadZipFS. As a user of zipsf, I need g…
chfw Jul 28, 2019
3edc314
:bug: on windows and python 3, fs.open_fs(osfs(~/).geturl('myfolder/s…
chfw Jul 28, 2019
a0d4c94
:microscope: all test cases are in and :sparkles: support geturl for …
chfw Aug 2, 2019
a854233
:fire: remove unwanted comment in code
chfw Aug 2, 2019
a01f07e
Merge remote-tracking branch 'upstream/master'
chfw Aug 2, 2019
ab4e2d5
:book: update change log and contributor md
chfw Aug 2, 2019
6a0f885
:short: update code with black
chfw Aug 2, 2019
a153367
:book: update change log
chfw Aug 2, 2019
065d753
:shirt: provide type info
chfw Aug 2, 2019
6a83318
:green_heart: update unit tests
chfw Aug 2, 2019
397e807
:fire: remove dead code
chfw Aug 2, 2019
d9d1490
:green_heart: update tarfs unit test
chfw Aug 2, 2019
9d1b0a0
:fire: remove unwanted change
chfw Aug 2, 2019
c9c6bcb
:short: run black over osfs.py
chfw Aug 3, 2019
f4290b8
:bug: fix hidden exception at fs.close() when opening an absent zip/…
chfw Aug 3, 2019
d236278
:pencil: update the behavior of geturl of zipfs and tarfs
chfw Aug 3, 2019
76e6566
:handshake: merge with latest master
chfw Aug 4, 2019
07617d2
:shirt: address review feedback
chfw Aug 6, 2019
ed9c2fa
:green_heart: fix broken tests
chfw Aug 6, 2019
e1ac859
:wheelchair: add helpful exception info to help developers, who creat…
chfw Aug 6, 2019
0387d5b
:bug: fix windows path test
chfw Aug 6, 2019
f29ed55
:sparkles: uniformly support fs purpose
chfw Aug 7, 2019
8dcfe4d
:hammer: quote around the root path. #340
chfw Aug 8, 2019
ab7ec66
:tractor: alternative file uri implementation
chfw Aug 8, 2019
a979470
:microscope: try windows path test case where unicode characters stay…
chfw Aug 8, 2019
7911bdf
:bug: fix unit test expectation because of the difference between win…
chfw Aug 8, 2019
7a5402b
:tractor: avoid Windows File URI for fs purpose
chfw Aug 8, 2019
eab400f
:bug: before quote, utf8 string needs to be encoded. https://stackove…
chfw Aug 8, 2019
7f222a4
:tractor: respect rfc 3986, where unicode will be quoted
chfw Aug 8, 2019
72ce8f4
:green_heart: :hammer: code refactor and fix broken unit tests
chfw Aug 8, 2019
5771586
:shirt: address review feedback from @lurch
chfw Aug 8, 2019
7656846
:green_heart: fix typo in code and :shirt: update assertions
chfw Aug 8, 2019
5d1efd7
:fire: remove unused variable
chfw Aug 8, 2019
29a394e
:shirt: address further comments from @lurch
chfw Aug 8, 2019
4243a59
:green_heart: update windows test case. fix the typo
chfw Aug 8, 2019
896e717
:bug: colon:tmp is bad path under windows
chfw Aug 8, 2019
f2fe735
:bug: forward slash on Windows is a valid path separator
chfw Aug 8, 2019
88a0b3a
:green_heart: fix unit tests on travis-ci
chfw Aug 8, 2019
c8685f6
:shirt: address review comments
chfw Aug 9, 2019
53f597a
:shirt: mypy compliance
chfw Aug 9, 2019
15c43d9
:shirt: dot the i and cross the t
chfw Aug 10, 2019
6f33be3
:handshake: merge with remote master
chfw Aug 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fs/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1652,7 +1652,7 @@ def hash(self, path, name):
fs.errors.UnsupportedHash: If the requested hash is not supported.

"""
_path = self.validatepath(path)
self.validatepath(path)
chfw marked this conversation as resolved.
Show resolved Hide resolved
try:
hash_object = hashlib.new(name)
except ValueError:
Expand Down