Windows path issues #967
Merged
Windows path issues #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the tests would still fail because NormalizePath would NOT work as the test results expected.
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests to handle paths in Windows. NormalizePath works properly but the tests would still fail because NormalizePath would NOT work as the test results expected. Verified on Windows with command:
/mingw64/bin/python -m unittest discover testsuite -vResults:
`D:\msys64\home\jpmugaas\pycodestyle/pycodestyle.py:124:30: W504 line break after binary operator
D:\msys64\home\jpmugaas\pycodestyle/pycodestyle.py:125:35: W504 line break after binary operator
D:\msys64\home\jpmugaas\pycodestyle/pycodestyle.py:298:46: W504 line break after binary operator
D:\msys64\home\jpmugaas\pycodestyle/pycodestyle.py:394:41: W504 line break after binary operator
D:\msys64\home\jpmugaas\pycodestyle/pycodestyle.py:401:75: W504ok
test_selftest (test_all.PycodestyleTestCase) ... ok
test_check_nullbytes (test_api.APITestCase) ... ok
test_check_unicode (test_api.APITestCase) ... ok
test_register_ast_check (test_api.APITestCase) ... ok
test_register_invalid_check (test_api.APITestCase) ... ok
test_register_logical_check (test_api.APITestCase) ... ok
test_register_physical_check (test_api.APITestCase) ... ok
test_styleguide (test_api.APITestCase) ... ok
test_styleguide_check_files (test_api.APITestCase) ... ok
test_styleguide_checks (test_api.APITestCase) ... ok
test_styleguide_continuation_line_outdented (test_api.APITestCase) ... ok
test_styleguide_excluded (test_api.APITestCase) ... ok
test_styleguide_ignore_code (test_api.APITestCase) ... ok
test_styleguide_init_report (test_api.APITestCase) ... ok
test_styleguide_options (test_api.APITestCase) ... ok
test_styleguide_unmatched_triple_quotes (test_api.APITestCase) ... ok
test_blank_line_between_decorator (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when the decorator is followed by a ... ok
test_blank_line_decorator (test_blank_lines.TestBlankLinesDefault)
It will accept the decorators which are adjacent to the function ... ok
test_initial_lines_more_blank (test_blank_lines.TestBlankLinesDefault)
It will trigger an error for more than 2 blank lines before the ... ok
test_initial_lines_one_blank (test_blank_lines.TestBlankLinesDefault)
It will accept 1 blank lines before the first line of actual ... ok
test_initial_lines_two_blanks (test_blank_lines.TestBlankLinesDefault)
It will accept 2 blank lines before the first line of actual ... ok
test_initial_no_blank (test_blank_lines.TestBlankLinesDefault)
It will accept no blank lines at the start of the file. ... ok
test_method_fewer_follow_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 1 blank line is ... ok
test_method_less_blank_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 1 blank lin is found ... ok
test_method_less_blank_lines_comment (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 1 blank lin is found ... ok
test_method_more_blank_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when more than 1 blank line is found ... ok
test_method_nested_fewer_follow_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 1 blank line is ... ok
test_method_nested_less_class (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 1 blank line is found ... ok
test_method_nested_ok (test_blank_lines.TestBlankLinesDefault)
Will not trigger an error when 1 blank line is found ... ok
test_top_level_fewer_blank_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less 2 blank lines are found ... ok
test_top_level_fewer_follow_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 2 blank lines are ... ok
test_top_level_fewer_follow_lines_comments (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when less than 2 blank lines are ... ok
test_top_level_good_follow_lines (test_blank_lines.TestBlankLinesDefault)
It not trigger an error when 2 blank lines are ... ok
test_top_level_more_blank_lines (test_blank_lines.TestBlankLinesDefault)
It will trigger an error when more 2 blank lines are found ... ok
test_initial_lines_one_blanks (test_blank_lines.TestBlankLinesTwisted)
It will accept less than 3 blank lines before the first line of ... ok
test_initial_lines_tree_blanks (test_blank_lines.TestBlankLinesTwisted)
It will accept 3 blank lines before the first line of actual ... ok
test_the_right_blanks (test_blank_lines.TestBlankLinesTwisted)
It will accept 3 blank for top level and 2 for nested. ... ok
test_top_level_fewer_blank_lines (test_blank_lines.TestBlankLinesTwisted)
It will trigger an error when less 3 blank lines are found ... ok
test_top_level_more_blank_lines (test_blank_lines.TestBlankLinesTwisted)
It will trigger an error when more 2 blank lines are found ... ok
test_multiline_ignore_parsing (test_parser.ParserTestCase) ... ok
test_multiline_trailing_comma_ignore_parsing (test_parser.ParserTestCase) ... ok
test_trailing_comma_ignore_parsing (test_parser.ParserTestCase) ... ok
test_vanilla_ignore_parsing (test_parser.ParserTestCase) ... ok
test_check_diff (test_shell.ShellTestCase) ... ok
test_check_noarg (test_shell.ShellTestCase) ... ok
test_check_non_existent (test_shell.ShellTestCase) ... ok
test_check_simple (test_shell.ShellTestCase) ... ok
test_check_stdin (test_shell.ShellTestCase) ... ok
test_print_usage (test_shell.ShellTestCase) ... ok
test_normalize_paths (test_util.UtilTestCase) ... ok
Ran 53 tests in 1.255s
OK`