Allow simple container literals as default values #358
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This change has no effect on typeshed. 🤖🎉 |
| field226: tuple[str | tuple[str, ...], ...] = ("foo", ("foo", "bar")) # Y015 Only simple default values are allowed for assignments | ||
| field227: dict[str, object] = {"foo": {"foo": "bar"}} # Y015 Only simple default values are allowed for assignments |
There was a problem hiding this comment.
I think these are decent examples, why we shouldn't forbid nesting. It's extra code and might occasionally be useful. If it becomes too complex, a manual reviewer can always point this out.
That said, this is not a show stopper.
There was a problem hiding this comment.
I thought you might say that :)
I guess my worry is that we've added most of our defaults up till now using stubdefaulter, which can result in a huge PR that we can't really review manually. I wouldn't really want a default such as {(("foo", "bar"), (1, 2): {("foo", "bar"): {1, 2, 3}}} added automatically by stubdefaulter in some bizarre third-party library to slip through human review by being bundled in a huge PR. But I guess that's pretty unlikely; I don't feel too strongly about disallowing nesting.
Resolves #357