Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make B017 also apply to BaseException #439

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

r-downing
Copy link
Contributor

on the subject of BaseException I thought it might make sense for this assertRaises check to apply to that as well

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. This is worse, IMO.

Wonder how noisy this will be ... but i think it's a big enough one for people to want to clean up in their code bases ...

@cooperlees cooperlees merged commit b25c5bd into PyCQA:main Dec 18, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants