Rename B028 to B907, making it optional/opinionated. #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster-node
that referenced
this pull request
Jan 16, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster-cookbook
that referenced
this pull request
Jan 16, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster
that referenced
this pull request
Jan 16, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
This was referenced Jan 16, 2023
cooperlees
requested changes
Jan 16, 2023
8 tasks
lukeseawalker
added a commit
to lukeseawalker/aws-parallelcluster-cookbook
that referenced
this pull request
Jan 17, 2023
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Signed-off-by: Luca Carrogu <[email protected]>
Merged
4 tasks
lukeseawalker
added a commit
to lukeseawalker/aws-parallelcluster-cookbook
that referenced
this pull request
Jan 17, 2023
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Signed-off-by: Luca Carrogu <[email protected]>
lukeseawalker
added a commit
to lukeseawalker/aws-parallelcluster-cookbook
that referenced
this pull request
Jan 17, 2023
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Luca Carrogu <[email protected]>
francesco-giordano
pushed a commit
to aws/aws-parallelcluster-cookbook
that referenced
this pull request
Jan 17, 2023
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Luca Carrogu <[email protected]>
jakkdl
force-pushed
the
opinionated_B028
branch
from
e76acd0 to
c8c8bfd
Compare
|
Fixed the location, so you can ship it straight away. |
8 tasks
cooperlees
approved these changes
Jan 18, 2023
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster
that referenced
this pull request
Jan 18, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
jdeamicis
added a commit
to aws/aws-parallelcluster
that referenced
this pull request
Jan 18, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
jdeamicis
added a commit
to jdeamicis/aws-parallelcluster-node
that referenced
this pull request
Feb 1, 2023
The B028 check is going to be made optional/opinionated in flake8-bugbear. See PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Jacopo De Amicis <[email protected]>
enrico-usai
pushed a commit
to enrico-usai/aws-parallelcluster-cookbook
that referenced
this pull request
Feb 2, 2023
This to solve check flake8 B017 Also disable B028 flake8-bugbear lint check recently implemented. The check is going to be disabled by the flake8-bugbear developers. See Rename B028 to B907, making it optional/opinionated. PyCQA/flake8-bugbear#333 Fix color formatting on flake8 style offenses. Signed-off-by: Luca Carrogu <[email protected]>
tobiasjj
added a commit
to lumicks/pylake
that referenced
this pull request
May 8, 2023
tobiasjj
added a commit
to lumicks/pylake
that referenced
this pull request
May 8, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 4, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 4, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 7, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 8, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 8, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 11, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 14, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Aug 15, 2023
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Mar 4, 2024
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Mar 4, 2024
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Mar 4, 2024
JoepVanlier
pushed a commit
to lumicks/pylake
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #329
Fixes #331
Fixes #332
For a certain definition of "fixes" at least, the check could perhaps be improved to make it less opinionated and more useful, but silencing lots of unnecessary warnings is the first step regardless.