Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document backwards incompatibilities #297

Closed
6 tasks
mikeboers opened this issue Mar 21, 2018 · 2 comments
Closed
6 tasks

Document backwards incompatibilities #297

mikeboers opened this issue Mar 21, 2018 · 2 comments

Comments

@mikeboers
Copy link
Member

Ripping this from #268 before closing it.

  • Document everything backwards incompatible in changelog:
    • Stream.encode returns a list of packets, instead of a single packet.
    • AudioFifo and AudioResampler will raise ValueError if input frames
      inconsistant pts.
    • CodecContext.rate has been removed, but proxied to VideoCodecContext.framerate
      and AudioCodecContext.sample_rate. The definition is effectively inverted from
      the old one (i.e. for 24fps it used to be 1/24 and is now 24/1).
    • Fractions (e.g. time_base, rate) will be None if they are invalid.
    • InputContainer.seek and Stream.seek will raise TypeError if given
      a float, when previously they converted it from seconds.
@jlaine
Copy link
Member

jlaine commented Nov 7, 2018

I'm closing this, for the past couple of releases we have correctly documented all API changes.

@jlaine jlaine closed this as completed Nov 7, 2018
@mikeboers
Copy link
Member Author

Thanks. We don't need to be that held back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants