Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage issues for v0.4.0 #268

Closed
10 tasks
mikeboers opened this issue Aug 27, 2017 · 7 comments
Closed
10 tasks

Triage issues for v0.4.0 #268

mikeboers opened this issue Aug 27, 2017 · 7 comments
Labels
meta About the project itself.

Comments

@mikeboers
Copy link
Member

mikeboers commented Aug 27, 2017

There has been a ton of work done since v0.3.3. We should cut out a new release.

However, I get the feeling that there are some regressions with it. We should triage the tickets still open since v0.3.3 to make sure they can be "ignored" for a new release.

(edited to just be the issues left to address)

  • Assert no blocking issues on GitHub:
  • Document everything backwards incompatible in changelog:
    • Stream.encode returns a list of packets, instead of a single packet.
    • AudioFifo and AudioResampler will raise ValueError if input frames
      inconsistant pts.
    • CodecContext.rate has been removed, but proxied to VideoCodecContext.framerate
      and AudioCodecContext.sample_rate. The definition is effectively inverted from
      the old one (i.e. for 24fps it used to be 1/24 and is now 24/1).
    • Fractions (e.g. time_base, rate) will be None if they are invalid.
    • InputContainer.seek and Stream.seek will raise TypeError if given
      a float, when previously they converted it from seconds.

😨

@mikeboers mikeboers added triage meta About the project itself. and removed triage labels Aug 27, 2017
@mikeboers
Copy link
Member Author

I'm tempted to just cut a v0.4.0 right now. The tests pass as is. That is what they are there for. If there is something showstopping surely someone would have either said by now, or it should be trivial to fix in a v0.4.1.

@Schamper
Copy link

Schamper commented Jan 6, 2018

Any update on this?

@mikeboers
Copy link
Member Author

No not really.

I've had a lot of personal stuff coming up. Honestly, while I've been reading all of the notifications from GitHub (as you can tell my be noticing this at all) I've been stuffing them into a "FLOSS" folder for when I eventually dig myself out.

As responsible as it may or may not be, I think I could be okay with releasing as-is, and seeing what happens. Can I get some 👍 on that?

@Schamper
Copy link

Schamper commented Jan 6, 2018

👍 from me

@tuxuser
Copy link

tuxuser commented Jan 6, 2018

I would appreciate that too!

@notedit
Copy link

notedit commented Mar 12, 2018

+1 Use pyav in my project.

@mikeboers
Copy link
Member Author

mikeboers commented Mar 21, 2018

So... uh... I just released v0.4.0.

A couple tests fail, I think because of FFmpeg changes in the ~6 months since I've run them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta About the project itself.
Projects
None yet
Development

No branches or pull requests

4 participants