Added <br/> and <seealso cref=xxx> #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not already exist, create it first.
Pxtl
approved these changes
Jun 19, 2018
| @@ -29,6 +29,14 @@ public TagRenderer(string formatString, Func<XElement, ConversionContext, IEnume | |||
| x.Element("members").Elements("member").ToMarkDown(context.MutateAssemblyName(x.Element("assembly").Element("name").Value)) | |||
| } | |||
| ), | |||
| ["br"] = new TagRenderer( | |||
| "\n", | |||
There was a problem hiding this comment.
For proper markdown, shouldn't it be "\n " with two trailing space afterwards? Then it's compatible with standard-markdown in addition to github-flavored markdown.
https://stackoverflow.blog/2009/10/15/markdown-one-year-later/
| (x, context) => new string[0] | ||
| ), | ||
| ["seealso"] = new TagRenderer( | ||
| "##### See also: {0}\n", |
There was a problem hiding this comment.
If possible (and consider this just a suggestion):
https://gist.github.com/asabaylus/3071099
Github-flavoured markdown automatically generates an anchor for each heading. That means that seealso could be an intra-document link.
|
I've created my own fork and taken an initial stab at trying to fix anchor links and such: It also adds other things beyond the scope of this PR, like a few more HTML and Sandcastle/NDoc tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.