Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for phase sub text in phase selector #381

Merged
merged 42 commits into from
Feb 10, 2021

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Feb 9, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: Add PR description to Changelog with the ID that matches this PR

Description

Added support for phase sub text in phase selector.

Same property PhaseSubText as in prosjektportalen, with fallback to PhasePurpose in case someone is using that today.

image

How to test

See #371

  • Create a new project
  • Verify correct PhaseSubText when mouse over each Phase indicator
  • Verify that correct PhaseSubText is displayed on screen
  • Change PhaseSubText in TermStore and verify updated text within the project
    Edit page and select webpart editor for Phase webpart.
  • Toggle "Vis fasetekst"; republish page and verfiy indications
  • With "Max lengde fasetekst" verify correct behavior (Test with both low / high number of characters)

Relevant issues

Closes #371

olemp added 30 commits February 9, 2021 19:23
@olemp olemp marked this pull request as ready for review February 10, 2021 08:36
@olemp olemp merged commit ca53c2b into dev Feb 10, 2021
@olemp olemp deleted the feature/phase-sub-text-371 branch February 10, 2021 10:41
@pzljanb pzljanb mentioned this pull request Feb 12, 2021
25 tasks
@pzljanb
Copy link
Contributor

pzljanb commented Feb 12, 2021

Konsept phase indicator (and TermStore) has PhaseLetter = 'X' in the 1.2.6 instance within Puzzlepart tenant.
Is this as a result from the installation package from GitHub, or from a manual update within this installation?
In case the installation package from GitHub contains the letter 'X'; this should be updated to 'K'
@olemp

@olemp
Copy link
Collaborator Author

olemp commented Feb 12, 2021

Konsept phase indicator (and TermStore) has PhaseLetter = 'X' in the 1.2.6 instance within Puzzlepart tenant.
Is this as a result from the installation package from GitHub, or from a manual update within this installation?
In case the installation package from GitHub contains the letter 'X'; this should be updated to 'K'
@olemp

Manual update in the tenant.

@danielwiese
Copy link

Solution looks good 😊👏

@pzljanb pzljanb added this to the 1.2.6 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "sub phase text" as part of the phase web part
3 participants