Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porteføljeoversikt: vis personlige visninger som egen "seksjon" #1063

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Mar 28, 2023

Pull request (PR)

Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot dev-branchen (venstre side). Sjekk commits og alle commit-meldingene.

Sjekklisten din

Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.

  • Sjekk at din branch ikke feiler på linting.
  • Legg ved beskrivelse i CHANGELOG, markert med ID av issue knyttet til PR-en
  • Angi korrekt Milestone på PR-en og issuet
  • Tilegn deg selv PR-en og legg til labels

Beskrivelse

Porteføljeoversikt: vis personlige visninger som egen "seksjon".

Dette vil fungere bedre enn å vise to ikoner for personlige visninger - ett brukerdefinert og ett for å indikere at visningen er personlig.

image

Relevante issues (hvis aktuelt)

Closes #1045

@olemp olemp added this to the 1.8.2 milestone Mar 28, 2023
@olemp olemp added the enhancement Request that will enhance the product label Mar 28, 2023
@olemp olemp self-assigned this Mar 28, 2023
@olemp olemp marked this pull request as ready for review March 28, 2023 13:09
@olemp olemp requested review from tarjeieo, okms and Remi749 as code owners March 28, 2023 13:09
tarjeieo
tarjeieo previously approved these changes Mar 29, 2023
Copy link
Member

@tarjeieo tarjeieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne løsningen likte jeg veldig godt 😁

Copy link
Member

@tarjeieo tarjeieo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STILL approved after changelog merge

@tarjeieo tarjeieo merged commit bac8fff into releases/1.8 Mar 29, 2023
@tarjeieo tarjeieo deleted the issues/1045 branch March 29, 2023 05:30
@olemp olemp modified the milestones: 1.8.2, 1.8.1 Mar 29, 2023
olemp added a commit that referenced this pull request Mar 29, 2023
olemp added a commit that referenced this pull request Mar 29, 2023
olemp added a commit that referenced this pull request Mar 29, 2023
* Porteføljeoversikt: vis personlige visninger som egen "seksjon"

* CHANGELOG

---------

Co-authored-by: Tarjei E. Ormestøyl <[email protected]>
@olemp olemp restored the issues/1045 branch March 29, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request that will enhance the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inkludere symbol for å indikere personlige visninger for Porteføljeoversikt
2 participants