Fikse feil på 'Hent prosjektdata' dialog #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olemp
requested changes
Mar 15, 2023
SharePointFramework/ProjectWebParts/src/data/SPDataAdapter/index.ts
Outdated
Show resolved
Hide resolved
SharePointFramework/ProjectWebParts/src/data/SPDataAdapter/index.ts
Outdated
Show resolved
Hide resolved
olemp
approved these changes
Mar 22, 2023
olemp
pushed a commit
that referenced
this pull request
Mar 29, 2023
* Add undefined check if templateParamters is null to prevent sync bug * changelog * Minor adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request (PR)
Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot dev-branchen (venstre side). Sjekk commits og alle commit-meldingene.
Sjekklisten din
Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.
linting.Milestonepå PR-en og issuetlabelsBeskrivelse
Fikse feil på 'Hent prosjektdata' dialog grunnet undefined templateParameters. Lagt til basic sjekk på om templateParameters er true slik at 'Hent prosjektdata' får hentet elementet riktig.
Hvordan teste
Vennligst beskriv hvordan noen andre (en vanlig bruker uten kodeferdigheter) kan teste denne PR-en. Følg eksempelet under, punktene du legger ved vil bli brukt når vi tester neste versjon av Prosjektportalen