Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel installation support #1047

Merged
merged 113 commits into from
Mar 30, 2023
Merged

Channel installation support #1047

merged 113 commits into from
Mar 30, 2023

Conversation

olemp
Copy link
Collaborator

@olemp olemp commented Mar 10, 2023

Pull request (PR)

Sørg for at du ber om PR for din branch (høyre side). Sørg for at du gjør en PR mot riktig release-branch (venstre side). Sjekk commits og alle commit-meldingene.

Sjekklisten din

Alle sjekkpunktene under må være sjekket av og godkjent for at vi skal kunne merge branchen din mot dev.

  • Sjekk at din branch ikke feiler på linting.
  • Legg ved beskrivelse i CHANGELOG, markert med ID av issue knyttet til PR-en
  • Angi korrekt Milestone på PR-en og issuet
  • Tilegn deg selv PR-en og legg til labels

Beskrivelse

Støtte for installasjonskanaler.

Se Installation channels for mer info.

Relevante issues (hvis aktuelt)

#1068 #1066

@olemp olemp changed the base branch from main to releases/1.8 March 10, 2023 15:58
@olemp
Copy link
Collaborator Author

olemp commented Mar 10, 2023

Initial POC for build a SPFx solution based on a channel config seems to work:

image

For now this is the channel config used:

{
  "name": "test",
  "spfx": {
    "solutions": {
      "PortfolioExtensions": {
        "id": "66dd93a0-5253-4d2b-90dc-769084c2d48f",
        "name": "Prosjektportalen 365 - Portfolio Extensions (test)",
        "zippedPackage": "solution/pp-portfolio-extensions-test.sppkg",
        "components": {
          "IdeaProcessingCommand": "abe92db3-8638-4d12-9ec1-cc59e3a28f3f",
          "IdeaProjectDataCommand": "eb2a3c19-840a-4f16-bae1-590d70c041c7",
          "IdeaRegistrationCommand": "328e66c3-6bec-4ac5-aadb-eaf7a7b0a0f3"
        }
      },
      "PortfolioWebParts": {
        "id": "d48d166f-0113-48d9-a8c3-3e317ec7bd17",
        "name": "Prosjektportalen 365 - Portfolio Web Parts (test)",
        "zippedPackage": "solution/pp-portfolio-web-parts-test.sppkg",
        "components": {
          "LatestProjectsWebPart": "7e76fae5-29a8-4609-907f-05dc51c4d453",
          "PortfolioAggregationWebPart": "9e709a07-3478-4b80-88b2-c1baeddee7fd",
          "PortfolioInsightsWebPart": "e9d1ce94-ea02-4d3e-b4c6-fdbc126c68b2",
          "PortfolioOverviewWebPart": "da158e04-42e5-49e7-a525-90ed0c9871fc",
          "ProjectListWebPart": "84d5ce65-22c1-4ef6-8fce-232d2a727150",
          "ProjectTimelineWebPart": "7769ffbe-8270-4a63-8e30-01249b83bf35",
          "ResourceAllocationWebPart": "930e0c21-1c43-4f5b-9041-66fb3d9be6e7"
        }
      },
      "ProgramWebParts": {
        "id": "9e4f0361-02d8-4580-8736-8bf3c6006297",
        "name": "Prosjektportalen 365 - Program Web Parts (test)",
        "zippedPackage": "solution/pp-program-web-parts-test.sppkg",
        "components": {
          "ProgramAdministrationWebpart": "dbafe7f9-ae7e-4cb6-87d1-0de2b1813488",
          "ProgramAggregationWebPart": "fb5fe9df-b0c4-4324-982e-497c4d0eb07f",
          "ProgramProjectOverviewWebPart": "29b6db79-d861-43b5-b8c2-2bcb7ca8e971",
          "ProgramTimelineWebPart": "681de079-d715-4d70-95ae-677cbdcb7d6e"
        }
      },
      "ProjectExtensions": {
        "id": "0cbcb6dd-2f3b-4ee8-a18a-b1ec6ead1b5d",
        "name": "Prosjektportalen 365 - Project Extensions (test)",
        "zippedPackage": "solution/pp-project-extensions-test.sppkg",
        "components": {
          "HelpContentApplicationCustomizer": "e9060560-8157-461c-bc46-09c7eb770e3f",
          "ProjectSetup": "a155438d-7a2d-4380-bae4-5b968671b67e",
          "ProjectUpgrade": "54643ed7-2b68-4f87-be27-9be4b8e4fac0",
          "TemplateSelectorCommand": "dbc0d1ea-72b5-4917-9dd1-b9793d1754b5"
        }
      },
      "ProjectWebParts": {
        "id": "eab721b7-4c75-454d-b96c-62def8b706e3",
        "name": "Prosjektportalen 365 - Project Web Parts (test)",
        "zippedPackage": "solution/pp-project-web-parts-test.sppkg",
        "components": {
          "OpportunityMatrixWebPart": "fe527c60-a46d-4340-aca9-e5919a45542b",
          "ProjectInformationWebPart": "2fef8362-c7bd-4525-b80b-48fcef3f21a2",
          "ProjectPhasesWebPart": "b054bcd0-9aa0-4e10-8533-1458a1c232a1",
          "ProjectStatusWebPart": "ee42a795-6e17-4776-9d13-ce333a9d246c",
          "ProjectTimelineWebPart": "f43c16e6-896b-487f-9734-4fc5a34b3bba",
          "RiskMatrixWebPart": "7675414c-8fe4-428c-93e1-54b24512d3ca"
        }
      }
    }
  }
}

FYI @Remi749 @okms @tarjeieo

Happy weekend! 🍺

@okms
Copy link
Contributor

okms commented Mar 10, 2023

Liker dette! Det eneste er å beholde id'er på tvers av bygg.

@olemp
Copy link
Collaborator Author

olemp commented Mar 29, 2023

@tarjeieo @Remi749 Kan en av dere opprette en issue som vi kan koble denne til?

@olemp olemp modified the milestones: 1.8.2, 1.9 Mar 29, 2023
@Remi749
Copy link
Collaborator

Remi749 commented Mar 29, 2023

@tarjeieo @Remi749 Kan en av dere opprette en issue som vi kan koble denne til?

#1068

@olemp olemp linked an issue Mar 29, 2023 that may be closed by this pull request
@olemp
Copy link
Collaborator Author

olemp commented Mar 29, 2023

For some reason /sites/pp365_channels_test ended up without navigation. Trying again here.

@Remi749
Copy link
Collaborator

Remi749 commented Mar 30, 2023

For some reason /sites/pp365_channels_test ended up without navigation. Trying again here.

Ser ting OK ut nå?

@olemp
Copy link
Collaborator Author

olemp commented Mar 30, 2023 via email

@olemp
Copy link
Collaborator Author

olemp commented Mar 30, 2023

For some reason /sites/pp365_channels_test ended up without navigation. Trying again here.

Ser ting OK ut nå?

Hvordan vil du teste det? Verifisere at https://puzzlepart.sharepoint.com/sites/pp365_channels_test fungerer?

Eller vil du også lage en ny temp kanalkonfigurasjon og bygge til denne? Da kan du egentlig justere på .github/workflows/ci-channel-test.yml til å bygge til din egen kanal.

Kan da være greit å ikke navnet (da får vi unødvendig rotete workflow-oversikt i GitHub UIet):

image

Revert også endringene du evt gjør på CI-filen

Jeg tenker at det holder med testing av testkanalen før merge til v1.9 branchen.

FYI @Remi749

@Remi749
Copy link
Collaborator

Remi749 commented Mar 30, 2023

For some reason /sites/pp365_channels_test ended up without navigation. Trying again here.

Ser ting OK ut nå?

Hvordan vil du teste det? Verifisere at https://puzzlepart.sharepoint.com/sites/pp365_channels_test fungerer?

Eller vil du også lage en ny temp kanalkonfigurasjon og bygge til denne? Da kan du egentlig justere på .github/workflows/ci-channel-test.yml til å bygge til din egen kanal.

Kan da være greit å ikke navnet (da får vi unødvendig rotete workflow-oversikt i GitHub UIet):

image

Revert også endringene du evt gjør på CI-filen

Jeg tenker at det holder med testing av testkanalen før merge til v1.9 branchen.

FYI @Remi749

Når pp365-channels-test fungerer som den skal så vil jeg si at PR kan merges. Selve testpunktene for PR-en vil omhandle testing av pp365-test og eventuelt en custom kanal.

@olemp olemp merged commit e4a479a into releases/1.9 Mar 30, 2023
@olemp olemp deleted the feat/channel-support branch March 30, 2023 12:34
@olemp olemp mentioned this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to Continuous Integration (GitHub Workflows/Actions) complexity: large Issue/PR with large complexity customer funded Issues funded by customer enhancement Request that will enhance the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kanalstøtte Last opp installasjonslogg-filen på installasjonselementet
4 participants