Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX improvements to Program #693

Closed
Remi749 opened this issue Apr 6, 2022 · 9 comments · Fixed by #880
Closed

UI/UX improvements to Program #693

Remi749 opened this issue Apr 6, 2022 · 9 comments · Fixed by #880
Assignees
Labels
complexity: small Issue/PR with small complexity enhancement Request that will enhance the product frontend Related to frontend
Milestone

Comments

@Remi749
Copy link
Collaborator

Remi749 commented Apr 6, 2022

Describe the solution you'd like
A list of various UI/UX improvements found throughout the Program module.

  1. Decorate links in "Administrasjon av underområder" the same way as other lists (see 'Gevinster' list for programs).
    a. This also applies for the "Legg til prosjekt" dialog
  2. Dialog with loading/shimmer when pressing "Legg til område" changes size after projects are loaded. Keep the same size.
  3. When making a project an "Overordnet" project, the dialog header should say: "Setter opp overordnet område" (see image of current header)
    image
  4. For consistency, searchlabel in OverordnetUsikkerheter should say "Søk i alle usikkerheter" Or the other lists should say something about "Søk i program..."
  5. Add a visual indication wether a project is "standard" or "Overordnet", either on the frontpage or elsewhere where it would be necessary.
  6. Update all column descriptions used in Program lists to mention program instead of project. (See description for "Programleveranser - Leveransebeskrivelse")
  7. After removing all "underområder" the "Fjern underordnet område" command button is still active, needs refresh to disable the state. This should become disabled when removing all sites (see image below of active state after deleting sites)
  8. Remove duplicate "Title" webpart prop from "Administrasjon av underområder" webpart page or rename the duplicate if needed.
  9. The webpart titles should be consistent. See comment
  10. Add title to "Oversikt" in Program, suggested text: "Oversikt over underområder"
  11. Disable "Legg til" button in "Legg til prosjekt" if none are selected.
  12. Fixed height (750px) for "Legg til prosjekt" dialog, but with a max-height to not get double scrollbars. Ex: "min-content"/"max-content" with padding. This will alleviate the amount of blank space if there are less than 15 projects to be selected from.
  13. Make the "Project" column in "OverordnetLeveranser" page clickable, to keep the UX consistent with "OverordnetGevinster" and "OverordnetUsikkerheter" pages.
  14. Add InformationMessage to "Administrasjon av underområder"

All points are open for debate of course.

@Remi749 Remi749 added enhancement Request that will enhance the product frontend Related to frontend complexity: small Issue/PR with small complexity labels Apr 6, 2022
@Remi749
Copy link
Collaborator Author

Remi749 commented Apr 7, 2022

Added points, 9-14

@tarjeieo
Copy link
Member

tarjeieo commented Apr 7, 2022

Love these improvements - feel free to work on them if you have time

@olemp
Copy link
Collaborator

olemp commented Apr 7, 2022

I like them too!

I'd also like to add one thing.

The webpart titles should be consistent.

image

Administrasjon av underområder is good.

image

Should be Oversikt over underområder in my opinion.

image

Should be something like Gevinster fra underområder. I think we should avoid the hyphen.

image

Tidslinje for underområder

And so on and so forth. I think we should make it more readable and avoid the hyphens, but you guys might not agree.

@Remi749
Copy link
Collaborator Author

Remi749 commented Apr 7, 2022

I agree, I'll add it as a point

@Remi749 Remi749 self-assigned this May 10, 2022
@Remi749 Remi749 added this to the 1.7.0 milestone May 24, 2022
@okms okms modified the milestones: 1.7.0, 1.8.0 Sep 14, 2022
@olemp olemp modified the milestones: 1.7.3, 1.8.0 Oct 28, 2022
@olemp olemp assigned olemp and unassigned Remi749 Nov 3, 2022
@Remi749
Copy link
Collaborator Author

Remi749 commented Nov 4, 2022

Solved

  1. Decorate links in "Administrasjon av underområder" the same way as other lists (see 'Gevinster' list for programs).
    a. This also applies for the "Legg til prosjekt" dialog
  2. Dialog with loading/shimmer when pressing "Legg til område" changes size after projects are loaded. Keep the same size.
  3. When making a project an "Overordnet" project, the dialog header should say: "Setter opp overordnet område" (see image of current header)
    image
  4. For consistency, searchlabel in OverordnetUsikkerheter should say "Søk i alle usikkerheter" Or the other lists should say something about "Søk i program..."
  5. Add a visual indication wether a project is "standard" or "Overordnet", either on the frontpage or elsewhere where it would be necessary.
  6. Update all column descriptions used in Program lists to mention program instead of project. (See description for "Programleveranser - Leveransebeskrivelse")
  7. After removing all "underområder" the "Fjern underordnet område" command button is still active, needs refresh to disable the state. This should become disabled when removing all sites (see image below of active state after deleting sites)
  8. Remove duplicate "Title" webpart prop from "Administrasjon av underområder" webpart page or rename the duplicate if needed.
  9. The webpart titles should be consistent. See comment
  10. Add title to "Oversikt" in Program, suggested text: "Oversikt over underområder"
  11. Disable "Legg til" button in "Legg til prosjekt" if none are selected.
  12. Fixed height (750px) for "Legg til prosjekt" dialog, but with a max-height to not get double scrollbars. Ex: "min-content"/"max-content" with padding. This will alleviate the amount of blank space if there are less than 15 projects to be selected from.
  13. Make the "Project" column in "OverordnetLeveranser" page clickable, to keep the UX consistent with "OverordnetGevinster" and "OverordnetUsikkerheter" pages.
  14. Add InformationMessage to "Administrasjon av underområder"

@olemp olemp assigned Remi749 and olemp and unassigned olemp and Remi749 Nov 4, 2022
olemp added a commit that referenced this issue Nov 7, 2022
…ld say: "Setter opp overordnet område" #693 [skip-install]
olemp added a commit that referenced this issue Nov 7, 2022
…ld say: "Setter opp overordnet område" #693 [skip-ci]
olemp added a commit that referenced this issue Nov 7, 2022
olemp added a commit that referenced this issue Nov 7, 2022
@olemp
Copy link
Collaborator

olemp commented Nov 7, 2022

Add InformationMessage to "Administrasjon av underområder"

What information message, @Remi749?

@Remi749
Copy link
Collaborator Author

Remi749 commented Nov 7, 2022

Add InformationMessage to "Administrasjon av underområder"

What information message, @Remi749?

Could be something like:

"Velg en eller flere prosjekter du ønsker å knytte til området. Området vil dukke opp som forelder, for prosjektene som er valgt, under Prosjektinformasjon."

@olemp
Copy link
Collaborator

olemp commented Nov 8, 2022

Add InformationMessage to "Administrasjon av underområder"

What information message, @Remi749?

Could be something like:

"Velg en eller flere prosjekter du ønsker å knytte til området. Området vil dukke opp som forelder, for prosjektene som er valgt, under Prosjektinformasjon."

Show it as a tooltip to avoid taking up the space all the time, @Remi749?

image

@Remi749
Copy link
Collaborator Author

Remi749 commented Nov 8, 2022

Add InformationMessage to "Administrasjon av underområder"

What information message, @Remi749?

Could be something like:
"Velg en eller flere prosjekter du ønsker å knytte til området. Området vil dukke opp som forelder, for prosjektene som er valgt, under Prosjektinformasjon."

Show it as a tooltip to avoid taking up the space all the time, @Remi749?

Good idea, I like it!

olemp added a commit that referenced this issue Nov 8, 2022
* UI/UX improvements to Program #693

* Disable "Legg til" button in "Legg til prosjekt" if none are selected #693

* Fixed height (750px) for "Legg til prosjekt" dialog #693

* Make the "Project" column in "OverordnetLeveranser" page clickable, to keep the UX consistent with "OverordnetGevinster" and "OverordnetUsikkerheter" pages.

* ProgramAdministrationInfoMessage

* TooltipHeader
@olemp olemp linked a pull request Nov 8, 2022 that will close this issue
6 tasks
@olemp olemp closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: small Issue/PR with small complexity enhancement Request that will enhance the product frontend Related to frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants