Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for locking weeks for editing #1251

Merged
merged 13 commits into from
Feb 10, 2025
Merged

Support for locking weeks for editing #1251

merged 13 commits into from
Feb 10, 2025

Conversation

olemp
Copy link
Contributor

@olemp olemp commented Jan 24, 2025

Your checklist for this pull request

  • Make sure you are requesting to pull a feature/bugfix branch (right side).
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off our dev branch.
  • Check your code additions locally using npm run watch
  • Make sure strings/resources are added using our resource files
  • Make sure CHANGELOG.md is updated if applicable
  • Make sure Smoke tests are updated if applicable

Review checklist

  • Tested locally

Description

Lock weeks for editing.

Related issues

Closes #1249

@olemp olemp self-assigned this Jan 24, 2025
@olemp olemp added enhancement New feature or request admin Related to Admin timesheet Related to Timesheet labels Jan 24, 2025
@okms
Copy link
Contributor

okms commented Jan 28, 2025

Couple of issues:

  1. Even though i cannot re-open the week, did tells me i can do so
    image

  2. where does the comment go when you close a week? Its not visible in the "Week status" view
    https://didapp-dev.azurewebsites.net/admin/weekStatus

  3. i can still forecast hours for weeks that are closed, should be disabled too for consistency

@olemp olemp marked this pull request as ready for review February 10, 2025 10:51
@auto-assign auto-assign bot requested review from damsleth and okms February 10, 2025 10:51
@olemp olemp changed the title Lock weeks for editing #1249 Support for locking weeks for editing Feb 10, 2025
@olemp olemp merged commit 9df0a29 into dev Feb 10, 2025
3 of 4 checks passed
@olemp olemp deleted the feat/lock-weeks branch February 10, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Related to Admin enhancement New feature or request timesheet Related to Timesheet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lock weeks for editing
2 participants