Added support for GET requests and code update for UE 5.4 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlinAleksey
reviewed
Aug 14, 2024
| bool FPsWebServerHandlerImpl::handlePost(CivetServer* Server, mg_connection* RequestConnection) | ||
| { | ||
| // Unique request id | ||
| const FGuid RequestId = FGuid::NewGuid(); | ||
|
|
||
| const auto Handler = OwnerHandler.Load(); | ||
| if (!Handler || Handler->IsPendingKill()) | ||
| if (!Handler || Handler == nullptr) |
There was a problem hiding this comment.
It would be better to use !IsValid(Handler) as a replacement for !Handler || Handler->IsPendingKill(). These are basically the same.
There was a problem hiding this comment.
Indeed, it hadn't occurred to me for some reason
IlinAleksey
reviewed
Aug 14, 2024
| @@ -166,7 +197,7 @@ FString FPsWebServerHandlerImpl::GetResponseData(const FGuid& RequestId, bool bT | |||
| Context.CancellationSource.Cancel(); | |||
|
|
|||
| const auto Handler = OwnerHandler.Load(); | |||
| if (Handler && !Handler->IsPendingKill()) | |||
| if (Handler && Handler == nullptr) | |||
There was a problem hiding this comment.
It would be better to use IsValid(Handler) as a replacement for Handler && !Handler->IsPendingKill().
IlinAleksey
reviewed
Aug 14, 2024
| @@ -27,6 +27,9 @@ class FPsWebServerHandlerImpl : public CivetHandler, public TSharedFromThis<FPsW | |||
| public: | |||
| FPsWebServerHandlerImpl(); | |||
|
|
|||
| /** Handle POST requests */ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this pull-request include:
UObjectBaseUtility::IsPendingKill()is deprecated)