make mypy recognize this package as having type hints #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #9 (we thought it was already fixed but it wasn't) |
|
seems like this wouldn't work with poetry python-poetry/poetry#1338 |
|
nevermind, it works with poetry and is documented here https://www.python.org/dev/peps/pep-0561/#packaging-type-information |
|
I will bump version now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy searches for this file, and if it's not found, it says that sansio_lsp_client has no type hints. I learned this by reading mypy's source code and I don't know if this is documented somewhere.