Girazoki xcm queues to maintenance mode #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girazoki
added
the
B7-runtimenoteworthy
librelois
reviewed
Nov 26, 2021
…nt to modify hook behavior
librelois
approved these changes
Nov 29, 2021
JoshOrndorff
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This PR adds support for disabling XCM in maintenance mode. We do so by making the maintenance_mode control two things:
xcmp and dmp handlers for the queues. This is gonna be called each time a new xcm message arrives. For maintenance mode, we have set a max_weight_limit of 0, which prevents any message from being executed and it enqueues them.
Pallet hooks. The main reason for making maintenance_mode control this is that both dmp and xcmp queues executed messages onIdle. I added the possibility of removing specific hooks in maintenance mode, and in the particular case of xcm, I did set this to 0.
This scenario is difficult to test, at least until we have an xcm mocker. So for now I just added a integration test, which does not run in the CI but anyone can verify it works.
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?