xcm queue paused and resume #1737

zqhxuyuan · 2021-12-29T03:38:23Z

closes: #1664

runtime/integration-tests/Cargo.toml

runtime/common/src/lib.rs

modules/transaction-pause/src/lib.rs

runtime/common/src/lib.rs

shaunxw

When paused, XCM messages should be queued in storage, and they needs to be replayed after resumed.

zqhxuyuan · 2022-01-03T15:02:39Z

When paused, XCM messages should be queued in storage, and they needs to be replayed after resumed.

@shaunxw @zjb0807 the implementation of processing DMP and HRMP message both first store data in relaychain, then the parachain sync relaychain data, and read messages by relay_client.runtime_api. when processing dmp and hrmp messages in parachain, it'll update ProcessedDownwardMessages and HrmpWatermark, and this two storage value will be included in collation info that will be the argument of relaychain to prune_dmq and prune_hrmp.

in current implementation, even though we ingnore invoke handle_dmp_messages or handle_xcmp_messages when xcm is paused, the ProcessedDownwardMessages and HrmpWatermark is updated anyway. so the relaychain still prune the dmp-queue and hrmp-queue.

going back to Tuple implementation of DmpMessageHandler and XcmpMessageHandler, if we disabled xcm, we could set Handler to (), and then xcm message is discarded. the reason why dmp/xcmp message is discarded is because of ProcessedDownwardMessages/HrmpWatermark is updated that we mentioned before.

fortunately, the dmp-queue implementation of DmpMessageHandler and xcmp-queue implementaion of XcmpMessageHandler both have some cache machanism which store cross chain message(origin from relaychain) in parachain. through this way, we don't need to implements how to queue message in storage and relayed after resumed.

dmp-queue use enqueue-page
xcmp-queue use InboundXcmpMessages

the premise of using these machanism is that we must call dmp-queue implementation of DmpMessageHandler and xcmp-queue implementaion of XcmpMessageHandler, that's why I set max_weight to 0 instead of didn't invoke them.
there's a same implements in moonbeam.

Ps. as currenty xcm-emulator use memory like(non-relayed) to test cross chain message, and for the case of dmp, relaychain may send duplicate dmp message to parachain. so the dmp-queue testcase may seems a little strange.

shaunxw

I think you're right. We can leverage the message cache to dmp and xcmp queue with max_weight.

Message sending in xcm-emulator can be improved later, at this time it's good to have manual tests to be safe.

runtime/common/src/lib.rs

dmp / xcmp queue will handle msg cache

zqhxuyuan · 2022-01-05T05:09:46Z

/bench runtime mandala module_transaction_pause

ghost · 2022-01-05T06:18:52Z

Finished benchmark for branch: xcm-pause

Benchmark: Benchmark Runtime Mandala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

Results

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 22.4
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 22.4
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 22.97
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 22.97
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 19.39
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 19.39
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 4.19
µs

Reads = 1
Writes = 0

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 4.19
µs

Reads = 1
Writes = 0

…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/mandala/src/weights/

zqhxuyuan · 2022-01-05T07:08:00Z

/bench runtime karura module_transaction_pause

ghost · 2022-01-05T07:08:02Z

Finished benchmark for branch: xcm-pause

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 22.43
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 22.43
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 22.65
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 22.65
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 19.43
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 19.43
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 4.208
µs

Reads = 1
Writes = 0

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 4.208
µs

Reads = 1
Writes = 0

…hmarks --features=with-karura-runtime -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

zqhxuyuan · 2022-01-05T07:32:49Z

/bench runtime acala module_transaction_pause

ghost · 2022-01-05T07:32:51Z

Finished benchmark for branch: xcm-pause

Benchmark: Benchmark Runtime Acala Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

Results

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 23.38
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 23.38
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause PausedTransactions (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 23.85
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 23.85
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:1)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 20.26
µs

Reads = 1
Writes = 1

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 20.26
µs

Reads = 1
Writes = 1

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Storage: TransactionPause XcmPaused (r:1 w:0)

Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 4.521
µs

Reads = 1
Writes = 0

Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 4.521
µs

Reads = 1
Writes = 0

…hmarks --features=with-acala-runtime -- benchmark --chain=acala-latest --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/acala/src/weights/

zqhxuyuan · 2022-01-06T09:22:14Z

the manual test (after pause) log show un-expected result:

the first time execute_xcm() is expected as max_weight is set to 0, so weight_limit: 0 results Weight limit reached! weight > weight_limit: 800000000 > 0
but there're another execute_xcm() later on set max_weight to 489869531000 make the xcm execution success.

2022-01-06 17:00:41.541 TRACE tokio-runtime-worker xcm::weight: [Relaychain] FixedWeightBounds message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([]) }])
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::weight: [Relaychain] FixedWeightBounds message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([]) }])
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::weight: [Relaychain] FixedWeightBounds message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(0) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }])
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::weight: [Relaychain] FixedWeightBounds message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]) }])
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::execute_xcm_in_credit: [Relaychain] origin: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Polkadot, id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }) }, message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]) }]), weight_limit: 1000000000, weight_credit: 1000000000
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::weight: [Relaychain] FixedWeightBounds message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]) }])
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::barriers: [Relaychain] TakeWeightCredit origin: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Polkadot, id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }) }, message: Xcm([TransferReserveAsset { assets: MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }]), dest: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }, xcm: Xcm([BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]) }]), max_weight: 1000000000, weight_credit: 1000000000
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::execute: [Relaychain] origin: Some(MultiLocation { parents: 0, interior: X1(AccountId32 { network: Polkadot, id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }) }), total_surplus/refunded: 0/0, error_handler_weight: 0
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::currency_adapter: [Relaychain] withdraw_asset what: MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }, who: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Polkadot, id: [212, 53, 147, 199, 21, 253, 211, 28, 97, 20, 26, 189, 4, 169, 159, 214, 130, 44, 133, 88, 133, 76, 205, 227, 154, 86, 132, 231, 165, 109, 162, 125] }) }
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::currency_adapter: [Relaychain] deposit_asset what: MultiAsset { id: Concrete(MultiLocation { parents: 0, interior: Here }), fun: Fungible(1000128000000) }, who: MultiLocation { parents: 0, interior: X1(Parachain(2000)) }
2022-01-06 17:00:42.060 TRACE tokio-runtime-worker xcm::execute_xcm_in_credit: [Relaychain] result: Ok(())

2022-01-06 17:00:42.223 DEBUG tokio-runtime-worker xcm::execute_xcm: [Parachain] origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), weight_limit: 0
2022-01-06 17:00:42.223 TRACE tokio-runtime-worker xcm::execute_xcm_in_credit: [Parachain] origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), weight_limit: 0, weight_credit: 0
2022-01-06 17:00:42.223 TRACE tokio-runtime-worker xcm::weight: [Parachain] FixedWeightBounds message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }])
2022-01-06 17:00:42.223 DEBUG tokio-runtime-worker xcm::execute_xcm_in_credit: [Parachain] Weight limit reached! weight > weight_limit: 800000000 > 0. (origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), weight_limit: 0, weight_credit: 0)

2022-01-06 17:00:42.225 DEBUG tokio-runtime-worker xcm::execute_xcm: [Parachain] origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), weight_limit: 489869531000
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::execute_xcm_in_credit: [Parachain] origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), weight_limit: 489869531000, weight_credit: 0
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::weight: [Parachain] FixedWeightBounds message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }])
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::barriers: [Parachain] TakeWeightCredit origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), max_weight: 800000000, weight_credit: 0
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::barriers: [Parachain] AllowTopLevelPaidExecutionFrom origin: MultiLocation { parents: 1, interior: Here }, message: Xcm([ReserveAssetDeposited(MultiAssets([MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }])), ClearOrigin, BuyExecution { fees: MultiAsset { id: Concrete(MultiLocation { parents: 1, interior: Here }), fun: Fungible(1000128000000) }, weight_limit: Limited(4000000000) }, DepositAsset { assets: Wild(All), max_assets: 1, beneficiary: MultiLocation { parents: 0, interior: X1(AccountId32 { network: Any, id: [48, 103, 33, 33, 29, 84, 4, 189, 157, 168, 142, 2, 4, 54, 10, 26, 154, 184, 184, 124, 102, 193, 188, 47, 205, 211, 127, 60, 34, 34, 204, 32] }) } }]), max_weight: 800000000, weight_credit: 0
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::execute: [Parachain] origin: Some(MultiLocation { parents: 1, interior: Here }), total_surplus/refunded: 0/0, error_handler_weight: 0
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::weight: [Parachain] FixedRateOfFungible::buy_weight weight: 800000000, payment: <wasm:stripped>
2022-01-06 17:00:42.225 TRACE tokio-runtime-worker xcm::execute_xcm_in_credit: [Parachain] result: Ok(())

zqhxuyuan · 2022-01-06T13:55:02Z

I found the second execute_xcm is invoked by on_idle

	#[pallet::hooks]
	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
		fn on_idle(_now: T::BlockNumber, max_weight: Weight) -> Weight {
			// on_idle processes additional messages with any remaining block weight.
			Self::service_queue(max_weight)
		}
	}

so we need other machanism to make sure don't invoke on_idle.

xlc · 2022-01-06T21:27:44Z

I can see few options:

queue the messages in our own pallet and send them to the xcmp/dmp queue upon resume
request XCMP/DMP queue pallet to implement a way to disable the on_idle handler
send suspend signal to the other chain so we won't receive any more messages

shaunxw · 2022-01-07T00:15:42Z

Or requesting hrmp/dmp pallets to be able to pause/resume channels.

xlc · 2022-01-31T21:54:09Z

paritytech/cumulus#896 is merged

zqhxuyuan · 2022-02-02T13:07:45Z

I'll continue this work after v0.9.16 is merged, as cumulus merge the PR to the master branch. also I think it'll be easy now, just need to add two config item to xcmp_queue::Config and do some test.

the dmp-queue seems haven't implement yet. so we may just first introduct xcmp.

zqhxuyuan added 2 commits December 29, 2021 11:37

xcm queue paused and resume

798e47a

tests of dmp and xcmp

be26d0b

zqhxuyuan commented Dec 30, 2021

View reviewed changes

runtime/integration-tests/Cargo.toml Outdated Show resolved Hide resolved

zqhxuyuan requested review from zjb0807, xlc and shaunxw December 30, 2021 14:02

zqhxuyuan commented Dec 30, 2021

View reviewed changes

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

weight

c0ccb33

zqhxuyuan marked this pull request as ready for review December 30, 2021 14:11

minor typo

117c2a1

zjb0807 reviewed Dec 31, 2021

View reviewed changes

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

shaunxw reviewed Dec 31, 2021

View reviewed changes

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

shaunxw previously requested changes Dec 31, 2021

View reviewed changes

review fix

bef19b9

zqhxuyuan added 2 commits January 3, 2022 23:17

Merge branch 'master' into xcm-pause

d0f99c1

unpause_xcm to resume_xcm

4ef7351

shaunxw reviewed Jan 4, 2022

View reviewed changes

runtime/common/src/lib.rs Outdated Show resolved Hide resolved

zqhxuyuan added 4 commits January 5, 2022 10:27

move to transaction-pause

cc3b1f0

Merge branch 'master' into xcm-pause

64ccd16

fmt

2680fb3

add transaction pause bench method

a1965eb

Acala Benchmarking Bot added 2 commits January 5, 2022 06:19

Merge remote-tracking branch 'origin/master' into xcm-pause

1402bf2

xlc mentioned this pull request Jan 6, 2022

Suspend xcmp/dmp queue paritytech/cumulus#891

Closed

zqhxuyuan mentioned this pull request Mar 17, 2022

add xcmp call and move xcmp dmp queue to seperate config file #1973

Merged

4meta5 mentioned this pull request Mar 22, 2022

{suspend, resume} xcm execution when {enter, exit}ing maintenance-mode moonbeam-foundation/moonbeam#1359

Merged

xcm queue paused and resume #1737

Are you sure you want to change the base?

xcm queue paused and resume #1737

Conversation

zqhxuyuan commented Dec 29, 2021

shaunxw left a comment

Choose a reason for hiding this comment

zqhxuyuan commented Jan 3, 2022 • edited Loading

shaunxw left a comment

Choose a reason for hiding this comment

zqhxuyuan commented Jan 5, 2022 • edited Loading

ghost commented Jan 5, 2022 • edited by ghost Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

zqhxuyuan commented Jan 5, 2022

ghost commented Jan 5, 2022 • edited by ghost Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

zqhxuyuan commented Jan 5, 2022

ghost commented Jan 5, 2022 • edited by ghost Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20 Raw Storage Info

Median Slopes Analysis

Min Squares Analysis

zqhxuyuan commented Jan 6, 2022 • edited Loading

zqhxuyuan commented Jan 6, 2022 • edited Loading

xlc commented Jan 6, 2022

shaunxw commented Jan 7, 2022

xlc commented Jan 31, 2022

zqhxuyuan commented Feb 2, 2022

zqhxuyuan commented Jan 3, 2022 •

edited

Loading

zqhxuyuan commented Jan 5, 2022 •

edited

Loading

ghost commented Jan 5, 2022 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Jan 5, 2022 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

ghost commented Jan 5, 2022 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "pause_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

Pallet: "module_transaction_pause", Extrinsic: "resume_xcm", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info

zqhxuyuan commented Jan 6, 2022 •

edited

Loading

zqhxuyuan commented Jan 6, 2022 •

edited

Loading