Add appendPageQueryParam parameter #8
Conversation
There was a problem hiding this comment.
Wow nice stuff! really appreciate the PR @benbristow ! 👏
Adds an option on each SitemapNode to disable the concatenation of the ?page= param to each loc
Now I understand the code .. but I'm missing one piece of info: what's the scenario where you don't want ?page=<...> ? Is that if you have only one page?
.gitignore
Outdated
| *.orig |
There was a problem hiding this comment.
What are these two files, for?
There was a problem hiding this comment.
No idea, but that was there before.
There was a problem hiding this comment.
ha oh yeah. it's a weird 'changed' line.
There was a problem hiding this comment.
oh wait. i ment -> what is an .idea/ folder? that's something u added.
There was a problem hiding this comment.
AH! is this related to JETBRAINS IntelliJ ?
There was a problem hiding this comment.
Sorry for the slow reply, been swamped with work.
Oh, it might have been. I've been using JetBrains Rider (Visual Studio alternative). I can remove if required?
There was a problem hiding this comment.
yes please @benbristow - then we can merge this PR. 👍
There was a problem hiding this comment.
Sorry, never received this ping. Updated.
Mainly if you've got a ?page= query param already there for pagination (or other query params there as it'd look a bit weird like I've never seen a sitemap with the ?page= query param before added to the |
.gitignore
Outdated
| *.orig |
There was a problem hiding this comment.
AH! is this related to JETBRAINS IntelliJ ?
|
I see the tests have failed. I can't seem to reproduce this locally after re-running in Visual Studio many times (10+). I think this is a blip on Appveyor's side, especially as I only updated the |
|
Error seems related to a missing file. I'll try and pull down the branch and test that locally, later. watch this space! |
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 89.68%
=========================================
Files ? 3
Lines ? 126
Branches ? 0
=========================================
Hits ? 113
Misses ? 13
Partials ? 0 Continue to review full report at Codecov.
|
|
Done @benbristow :) I fixed the issue (ref 83e12a2) and merged. NuGet has also been updated. It's now version 3.1.0. Thanks heaps for the PR - really appreciate it. |
Adds an option on each SitemapNode to disable the concatenation of the
?page=param to eachloc