feat: add support for Magento v2.4.4 and v2.4.5 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 3.0 supports PHP 8.1
PHP8 requires return type specified on implementation when specified in declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is non-breaking for this package, however the underlying
pureclarity/php-sdkhas changed, so consumers should be aware of the update.For @jcbarton I would probably re-release this as a major version bump (
7.0.0) give the PHP8 changes of the sdk.I've also added some additional CI checks to give us better quality assurances.
Some deprecation warnings remain in the unit tests, but these are non impactful currently.
These should be replaced with
withConsecutiveas documented here: sebastianbergmann/phpunit#4297