Adjust precompile workload to avoid warnings #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.10 during precompilation has some warnings due to tasks hanging. This is due to the `Malt` workers. Skip these parts of the precompilation so that we don't run into that warning. Fixes #8.
|
Doesn't appear to affect latency much at all, so this'll be fine. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 84.31% 84.35% +0.04%
==========================================
Files 5 5
Lines 357 358 +1
==========================================
+ Hits 301 302 +1
Misses 56 56 ☔ View full report in Codecov by Sentry. |
jkrumbiegel
approved these changes
Jan 15, 2024
Starts up worker processes that don't immediately close from what I can tell. It's not a critical issue since they do eventually close (and don't hang indefinitely), it just looks weird seeing the warning in precompilation. |
Nothing at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.10 during precompilation has some warnings due to tasks hanging. This is due to the
Maltworkers. Skip these parts of the precompilation so that we don't run into that warning.Fixes #8.