Fix package integration hooks logic #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
==========================================
+ Coverage 84.03% 84.31% +0.28%
==========================================
Files 5 5
Lines 357 357
==========================================
+ Hits 300 301 +1
+ Misses 57 56 -1 ☔ View full report in Codecov by Sentry. |
Only attempt to rerun hooks for packages that have actually already been loaded, otherwise version checks will fail since the package isn't actually loaded. Cache package version as an optimisation.
MichaelHatherly
force-pushed
the
mh/pkg-load-hooks-fix
branch
from
f935c8e to
3cb8c37
Compare
jkrumbiegel
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to rerun hooks for packages that have actually already been loaded, otherwise version checks will fail since the package isn't actually loaded. Cache package version as an optimisation.