Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile server machinery #55

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Precompile server machinery #55

merged 2 commits into from
Mar 6, 2024

Conversation

jkrumbiegel
Copy link
Collaborator

@jkrumbiegel jkrumbiegel commented Mar 6, 2024

To improve responsiveness of first render using quarto, include a basic server socket connection pass in the precompilation run. Ideally, this would include run but it seems that wasn't desired due to #8

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.77%. Comparing base (49e3c3c) to head (d1d6341).
Report is 7 commits behind head on main.

Files Patch % Lines
src/precompile.jl 95.65% 1 Missing ⚠️
src/socket.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   85.62%   85.77%   +0.14%     
==========================================
  Files           5        5              
  Lines         473      499      +26     
==========================================
+ Hits          405      428      +23     
- Misses         68       71       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelHatherly MichaelHatherly merged commit 74f9524 into main Mar 6, 2024
8 of 10 checks passed
@MichaelHatherly MichaelHatherly deleted the jk/precompile-server branch March 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants