Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return julia error so that quarto can display why execution failed #53

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jkrumbiegel
Copy link
Collaborator

Just had to debug a situation where a file couldn't be executed using quarto, had to resort to running QuartoNotebookRunner manually because the only response I got was running file failed.

Sending the full julia error back should make this easier in the future.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.83%. Comparing base (65f8689) to head (a4ac96c).

Files Patch % Lines
src/socket.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files           5        5           
  Lines         473      473           
=======================================
  Hits          406      406           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelHatherly
Copy link
Collaborator

Rebase onto #52 once that is merged since it appears to help CI on macos 1.7.

@MichaelHatherly MichaelHatherly merged commit b3d6736 into main Mar 6, 2024
7 of 10 checks passed
@MichaelHatherly MichaelHatherly deleted the jk/return-error branch March 6, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants