Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unpopulated notebook options during worker package init #167

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

MichaelHatherly
Copy link
Collaborator

Handles the case where a package that triggers extension loading within this package's worker package is already available in the process that is running the notebook (e.g. a system image containing Makie).

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files Patch % Lines
src/QuartoNotebookWorker/src/refresh.jl 0.00% 12 Missing ⚠️
...ookWorker/ext/QuartoNotebookWorkerCairoMakieExt.jl 0.00% 5 Missing ⚠️
src/QuartoNotebookWorker/src/render.jl 0.00% 2 Missing ⚠️
src/QuartoNotebookWorker/src/NotebookState.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Base automatically changed from mh/warning to main July 25, 2024 07:41
@MichaelHatherly MichaelHatherly force-pushed the mh/worker-options-fix branch 4 times, most recently from 726f7de to 82841dc Compare July 25, 2024 15:07
@MichaelHatherly MichaelHatherly marked this pull request as ready for review July 25, 2024 15:16
@MichaelHatherly MichaelHatherly force-pushed the mh/worker-options-fix branch from 82841dc to aa71c70 Compare July 26, 2024 14:57
@MichaelHatherly MichaelHatherly merged commit 0938d15 into main Jul 26, 2024
8 of 9 checks passed
@MichaelHatherly MichaelHatherly deleted the mh/worker-options-fix branch July 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants