Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document using Requires.jl for extending in 3rd-party packages #146

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

MichaelHatherly
Copy link
Collaborator

@MichaelHatherly MichaelHatherly commented Jun 6, 2024

Since packages that would want to extend QNW would need QuartoNotebookWorker in their weakdeps and that requires that the weakdep be registered for registry CI checks to pass. Extending with Requires.jl does not have that issue since it is dynamic rather than based on what the manifest resolves to.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (85f6510) to head (ef91163).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          27       27           
  Lines        1209     1209           
=======================================
  Hits          646      646           
  Misses        563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelHatherly MichaelHatherly changed the title Worker package adjustments Document using Requires.jl for extending in 3rd-party packages Jun 6, 2024
@MichaelHatherly MichaelHatherly merged commit f161fd9 into main Jun 6, 2024
10 checks passed
@MichaelHatherly MichaelHatherly deleted the mh/worker-package branch June 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant