Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly render PlotlyJS/PlotlyBase objects #51

Closed
MichaelHatherly opened this issue Mar 1, 2024 · 0 comments · Fixed by #52
Closed

Correctly render PlotlyJS/PlotlyBase objects #51

MichaelHatherly opened this issue Mar 1, 2024 · 0 comments · Fixed by #52
Assignees
@MichaelHatherly

Comments

@MichaelHatherly
Copy link
Collaborator

Currently they don't render to appropriate outputs. Ideally html output from quarto render should result in plotly.js interactive plots when https://github.com/JuliaPlots/PlotlyJS.jl objects are rendered. In other "static" outputs they should fall back on PNG/SVG as appropriate. Will likely require additions to the worker package hooks to tailor the rendering behaviour of those objects.
@MichaelHatherly MichaelHatherly self-assigned this Mar 1, 2024
MichaelHatherly added a commit that referenced this issue Mar 5, 2024
@MichaelHatherly
Fix #51
a9cd5e6 
Render inline HTML for plotly plots rather than complete HTML documents.
@MichaelHatherly MichaelHatherly linked a pull request Mar 5, 2024 that will close this issue
Fix #51 #52
Merged
MichaelHatherly added a commit that referenced this issue Mar 6, 2024
@MichaelHatherly
Merge pull request #52 from PumasAI/mh/plotly-inline-render
65f8689 
Fix #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelHatherly MichaelHatherly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #51 PumasAI/QuartoNotebookRunner.jl
1 participant
@MichaelHatherly