Handle application/pdf mimetypes (#136)

src/QuartoNotebookWorker/ext/QuartoNotebookWorkerPlotsExt.jl

@@ -33,12 +33,8 @@ function configure()
         dpi_kwargs = Dict{Symbol,Any}()
     end
 
-    pkgid = Base.PkgId(Plots)
-    if (QuartoNotebookWorker._pkg_version(pkgid) < v"1.28.1") && (fm.fig_format == "pdf")
-        Plots.gr(; size_kwargs..., fmt = :png, dpi_kwargs...)
-    else
-        Plots.gr(; size_kwargs..., fmt = fm.fig_format, dpi_kwargs...)
-    end
+    Plots.gr(; size_kwargs..., dpi_kwargs...)
+
     return nothing
 end
 

src/QuartoNotebookWorker/src/render.jl

@@ -396,6 +396,7 @@ function render_mimetypes(value, cell_options)
             "text/latex",
             "image/svg+xml",
             "image/png",
+            "application/pdf",
             "application/json",
         ]
     end

src/server.jl

@@ -971,6 +971,7 @@ just has to provide bytes.
 function process_results(dict::Dict{String,@NamedTuple{error::Bool, data::Vector{UInt8}}})
     funcs = Dict(
         "application/json" => json_reader,
+        "application/pdf" => Base64.base64encode,
         "text/plain" => String,
         "text/markdown" => String,
         "text/html" => String,

test/examples/integrations/PlotsPDF.qmd

@@ -0,0 +1,17 @@
+---
+title: Plots integration
+fig-width: 4
+fig-height: 3
+fig-dpi: 150
+fig-format: pdf
+julia:
+    exeflags: ["--project=Plots"]
+---
+
+```{julia}
+import Plots
+```
+
+```{julia}
+Plots.plot(Plots.fakedata(50, 5), w = 3)
+```

test/testsets/integrations/Plots.jl

@@ -12,3 +12,12 @@ test_example(joinpath(@__DIR__, "../../examples/integrations/Plots.qmd")) do jso
     @test cell["outputs"][1]["metadata"]["image/png"] ==
           Dict("width" => 575, "height" => 432) # Plots does not seem to follow standard dpi rules so the values don't match Makie
 end
+
+test_example(joinpath(@__DIR__, "../../examples/integrations/PlotsPDF.qmd")) do json
+    cells = json["cells"]
+
+    cell = cells[4]
+    output = cell["outputs"][1]
+
+    @test !isempty(output["data"]["application/pdf"])
+end