Skip to content

Fix new game menu being closeable without displaying the main menu #294

Fix new game menu being closeable without displaying the main menu

Fix new game menu being closeable without displaying the main menu #294

Triggered via push January 2, 2025 23:15
Status Failure
Total duration 2m 40s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 30 warnings
macOS-14
Process completed with exit code 1.
ubuntu-22
Process completed with exit code 1.
windows-server-2022
Process completed with exit code 1.
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector2.cs#L119
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L244
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'format' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'formatProvider' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/EntityBase.cs#L17
Non-nullable property 'Parent' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1483
Field 'OrbitalMath.Orbit.T' is never assigned to, and will always have its default value 0
macOS-14: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1482
Field 'OrbitalMath.Orbit.position' is never assigned to, and will always have its default value
macOS-14: Pulsar4X/GameEngine/JumpPoints/JPSurveyProcessor.cs#L46
Possible null reference argument for parameter 'b' in 'double MoveMath.GetDistanceBetween(Entity a, Entity b)'.
macOS-14: Pulsar4X/GameEngine/JumpPoints/JPSurveyProcessor.cs#L68
Possible null reference argument for parameter 'entity' in 'void JPSurveyProcessor.ProcessEntity(Entity entity, int deltaSeconds)'.
macOS-14: Pulsar4X/GameEngine/Movement/WarpMove/WarpMoveProcessor.cs#L83
Possible null reference argument for parameter 'entity' in 'void WarpMoveProcessor.WarpMove(Entity entity, WarpMovingDB moveDB, DateTime toDateTime)'.
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector2.cs#L119
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L244
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'format' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'formatProvider' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/EntityBase.cs#L17
Non-nullable property 'Parent' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1483
Field 'OrbitalMath.Orbit.T' is never assigned to, and will always have its default value 0
ubuntu-22: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1482
Field 'OrbitalMath.Orbit.position' is never assigned to, and will always have its default value
ubuntu-22: Pulsar4X/GameEngine/Engine/Processors/PulseActionProcessor.cs#L21
Possible null reference argument for parameter 'game' in 'void InterSystemJumpProcessor.JumpOut(Game game, SystemEntityJumpPair jumpPair)'.
ubuntu-22: Pulsar4X/GameEngine/Engine/Processors/PulseActionProcessor.cs#L22
Possible null reference argument for parameter 'game' in 'void InterSystemJumpProcessor.JumpIn(Game game, SystemEntityJumpPair jumpPair)'.
ubuntu-22: Pulsar4X/GameEngine/Engine/Auth/Player.cs#L180
'StreamingContext.State' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' (https://aka.ms/dotnet-warnings/SYSLIB0050)
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector2.cs#L119
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L244
Nullability of type of parameter 'obj' doesn't match overridden member (possibly because of nullability attributes).
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'format' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/Vector3.cs#L366
Nullability of reference types in type of parameter 'formatProvider' of 'string Vector3.ToString(string format, IFormatProvider formatProvider)' doesn't match implicitly implemented member 'string IFormattable.ToString(string? format, IFormatProvider? formatProvider)' (possibly because of nullability attributes).
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/DataStructures/EntityBase.cs#L17
Non-nullable property 'Parent' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1482
Field 'OrbitalMath.Orbit.position' is never assigned to, and will always have its default value
windows-server-2022: Pulsar4X/Pulsar4X.OrbitalMath/OrbitalMath.cs#L1483
Field 'OrbitalMath.Orbit.T' is never assigned to, and will always have its default value 0
windows-server-2022: Pulsar4X/GameEngine/Engine/Auth/Player.cs#L180
'StreamingContext.State' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' (https://aka.ms/dotnet-warnings/SYSLIB0050)
windows-server-2022: Pulsar4X/GameEngine/Engine/Auth/Player.cs#L180
'StreamingContextStates' is obsolete: 'Formatter-based serialization is obsolete and should not be used.' (https://aka.ms/dotnet-warnings/SYSLIB0050)
windows-server-2022: Pulsar4X/GameEngine/Engine/OrbitMath.cs#L235
Converting null literal or possible null value to non-nullable type.