Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description container #213

Merged
merged 26 commits into from
Jul 12, 2022
Merged

Description container #213

merged 26 commits into from
Jul 12, 2022

Conversation

Noamili
Copy link
Contributor

@Noamili Noamili commented Jun 17, 2022 •
edited
Loading

TODO change the target branch to staging

close #196

Screen.Recording.2022-06-17.at.15.58.24.mov
Screen.Recording.2022-06-17.at.16.01.06.mov

@netlify
Copy link

netlify bot commented Jun 17, 2022 •
edited
Loading

✅ Deploy Preview for agitated-hoover-61371e ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 096d98b
🔍 Latest deploy log https://app.netlify.com/sites/agitated-hoover-61371e/deploys/62ca8402add699000a26fa61
😎 Deploy Preview https://deploy-preview-213--agitated-hoover-61371e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Preview on netlify: https://deploy-preview-213--pull-request.netlify.app/

MichalPorag
MichalPorag requested changes Jun 18, 2022
View reviewed changes
Copy link
Collaborator

@MichalPorag MichalPorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! thank you so much :)
Let's go over the CSS structure together in Zoom.

components/layout/layout.module.scss Outdated Show resolved Hide resolved
components/layout/layout.module.scss Show resolved Hide resolved
components/layout/layout.module.scss Outdated Show resolved Hide resolved
components/layout/navbar/navbar.tsx Outdated Show resolved Hide resolved
styles/Home.module.scss Outdated Show resolved Hide resolved
@Noamili Noamili changed the base branch from master to staging June 28, 2022 16:07
@Noamili Noamili requested a review from MichalPorag June 28, 2022 16:09
OmriBarZik and others added 5 commits July 2, 2022 10:06
@OmriBarZik
chore: remove idea folder (Pull-Request-Community#236)
554b82d
@shir22
updating readme: custom image (Pull-Request-Community#239)
5e9ea19
@lirantal
test: add e2e infra with playwright and a sample test (Pull-Request-C…
365afa6 
…ommunity#235)

* test: add e2e infra with playwright and a sample test

* test: add github action for e2e test

* test: add config for framework spin-up
@Yedidyar
Yedidyar/issue167 (Pull-Request-Community#240)
b452576 
* feat: add Yedidya Rashi profile (Pull-Request-Community#220)

* fix: randomShuffle isn't working correctly  (Pull-Request-Community#167)
@Yedidyar
fix(Description): wrap descriptionHeight with useEffect (Pull-Request…
d7e85d9 
…-Community#243)

see more about the issue:
https://stackoverflow.com/questions/62336340/cannot-update-a-component-while-rendering-a-different-component-warning
@Noamili Noamili force-pushed the description-container branch from 8cbbaf4 to 70f6864 Compare July 3, 2022 17:57
@Noamili Noamili force-pushed the description-container branch from 8f00569 to c09ff1d Compare July 8, 2022 12:37
@Noamili Noamili force-pushed the description-container branch from c09ff1d to 554f00c Compare July 8, 2022 12:40
@Noamili
Copy link
Contributor Author

Noamili commented Jul 8, 2022

@MichalPorag ready for merge

MichalPorag
MichalPorag approved these changes Jul 9, 2022
View reviewed changes
Copy link
Collaborator

@MichalPorag MichalPorag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat work!

@MichalPorag
Copy link
Collaborator

@Noamili, I tried to fix the conflicts on the website, but it wasn't enough. Can you please fix them?

@Noamili Noamili force-pushed the description-container branch from 7b5d857 to 1657f59 Compare July 10, 2022 07:40
@Noamili
Copy link
Contributor Author

Noamili commented Jul 10, 2022 •
edited
Loading

@Noamili, I tried to fix the conflicts on the website, but it wasn't enough. Can you please fix them?
can be merged! @MichalPorag

@MichalPorag MichalPorag merged commit b9dd209 into Pull-Request-Community:staging Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPorag MichalPorag MichalPorag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update description container design
8 participants
@Noamili @MichalPorag @Yedidyar @OmriBarZik @shir22 @lirantal @InbarDanieli @noamilsh